Make value_must_coerce_to_target return a bool

... and move comment to header file.

gdb/ChangeLog:

	* valops.c (value_must_coerce_to_target): Change return type to
	bool.
	* value.h (value_must_coerce_to_target): Likewise.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 0121791a22b22c0b44387d113e36c180c8aef4d6..49ccba76f14966dc4e1295f173b1759f20930bbf 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * valops.c (value_must_coerce_to_target): Change return type to
+       bool.
+       * value.h (value_must_coerce_to_target): Likewise.
+
 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 
        * breakpoint.c (is_hardware_watchpoint): Remove

diff --git a/gdb/valops.c b/gdb/valops.c
index 82b54561c244b2d420f3cf718c3bec83e251bacf..0f6ff7b0a5722cd678388b1d016763217d690c26 100644 (file)
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1343,10 +1343,9 @@ address_of_variable (struct symbol *var, const struct block *b)
   return val;
 }
 
-/* Return one if VAL does not live in target memory, but should in order
-   to operate on it.  Otherwise return zero.  */
+/* See value.h.  */
 
-int
+bool
 value_must_coerce_to_target (struct value *val)
 {
   struct type *valtype;
@@ -1355,7 +1354,7 @@ value_must_coerce_to_target (struct value *val)
   if (VALUE_LVAL (val) != not_lval
       && VALUE_LVAL (val) != lval_internalvar
       && VALUE_LVAL (val) != lval_xcallable)
-    return 0;
+    return false;
 
   valtype = check_typedef (value_type (val));
 
@@ -1364,9 +1363,9 @@ value_must_coerce_to_target (struct value *val)
     case TYPE_CODE_ARRAY:
       return TYPE_VECTOR (valtype) ? 0 : 1;
     case TYPE_CODE_STRING:
-      return 1;
+      return true;
     default:
-      return 0;
+      return false;
     }
 }
 

diff --git a/gdb/value.h b/gdb/value.h
index f96b095941a2471844c6cd0f1ec2db039ffa5815..9f55408dde0b6a6646b56e7a4d8ab0609305c6a5 100644 (file)
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -793,7 +793,10 @@ extern struct value *value_ptradd (struct value *arg1, LONGEST arg2);
 
 extern LONGEST value_ptrdiff (struct value *arg1, struct value *arg2);
 
-extern int value_must_coerce_to_target (struct value *arg1);
+/* Return true if VAL does not live in target memory, but should in order
+   to operate on it.  Otherwise return false.  */
+
+extern bool value_must_coerce_to_target (struct value *arg1);
 
 extern struct value *value_coerce_to_target (struct value *arg1);