anv: turn on samplerAnisotropy in VkPhysicalDeviceFeatures
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>
Fri, 7 Oct 2016 12:53:04 +0000 (13:53 +0100)
committerLionel Landwerlin <lionel.g.landwerlin@intel.com>
Mon, 10 Oct 2016 08:25:38 +0000 (09:25 +0100)
According to the Vulkan spec 5.63.4 :

  samplerAnisotropy indicates whether anisotropic filtering is supported. If
  this feature is not enabled, the maxAnisotropy member of the
  VkSamplerCreateInfo structure must be 1.0.

Since we already set maxAnisotropy to 16 and program the hardware according
to the VkSamplerCreateInfo.maxAnisotropy, it seems we can turn this on.

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
src/intel/vulkan/TODO
src/intel/vulkan/anv_device.c

index 9ac63ebc75e17f4709886603dbbbf118a3b7522b..4c3faadeb8d2f77c5387b3bd1859de3758d0424d 100644 (file)
@@ -5,7 +5,6 @@ Missing Features:
  - FP64
  - Tessellation
  - Cull and Clip Distance
- - Sampler anisotropy (Is there anything to do here?)
  - Image Gather Extended
  - Storage Image Without Format
  - Investigate CTS failures on HSW
index 9f8fa33e2f9a3840135a71a3fc8b8a5e19a0fa26..02246ba8e8a6d956e96f10b1d6c5f0bf6cfee83e 100644 (file)
@@ -418,7 +418,7 @@ void anv_GetPhysicalDeviceFeatures(
       .largePoints                              = true,
       .alphaToOne                               = true,
       .multiViewport                            = true,
-      .samplerAnisotropy                        = false, /* FINISHME */
+      .samplerAnisotropy                        = true,
       .textureCompressionETC2                   = pdevice->info.gen >= 8 ||
                                                   pdevice->info.is_baytrail,
       .textureCompressionASTC_LDR               = pdevice->info.gen >= 9, /* FINISHME CHV */