re PR tree-optimization/91355 (optimized code does not call destructor while unwindin...

	PR tree-optimization/91355
	* tree-ssa-sink.c (select_best_block): Use >= rather than >
	for early_bb scaled count with best_bb count comparison.

	* g++.dg/torture/pr91355.C: New test.

From-SVN: r278548

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index e705e4a2e99f37db644757b11b590f8b337abf58..82cecf3c82a8bed079840ad0096fc863733473c2 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,9 @@
 2019-11-21  Jakub Jelinek  <jakub@redhat.com>
 
+       PR tree-optimization/91355
+       * tree-ssa-sink.c (select_best_block): Use >= rather than >
+       for early_bb scaled count with best_bb count comparison.
+
        * ipa-fnsummary.h (enum ipa_hints_vals): Fix comment typo,
        preffer -> prefer.
        * ipa-inline.c (edge_badness): Likewise.

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 5b0217c7118e24676fc5b0e5d38296c98ca1120a..7ff0ce70c20a77d9c353fcb8890edb3e67233fe6 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-21  Jakub Jelinek  <jakub@redhat.com>
+
+       PR tree-optimization/91355
+       * g++.dg/torture/pr91355.C: New test.
+
 2019-11-21  Iain Sandoe  <iain@sandoe.co.uk>
 
        * gcc.dg/gnu2x-attrs-1.c: Expect an error for the alias case

diff --git a/gcc/testsuite/g++.dg/torture/pr91355.C b/gcc/testsuite/g++.dg/torture/pr91355.C
new file mode 100644 (file)
index 0000000..7a385dc
--- /dev/null
+++ b/gcc/testsuite/g++.dg/torture/pr91355.C
@@ -0,0 +1,28 @@
+// PR tree-optimization/91355
+// { dg-do run }
+// { dg-options "-std=c++14" }
+
+unsigned int d = 0;
+
+struct S {
+  S () { d++; }
+  S (const S &) { d++; }
+  ~S () { d--; }
+};
+
+void
+foo (int i) throw (int) // { dg-warning "dynamic exception specifications are deprecated" }
+{
+  if (i == 0)
+    throw 3;
+  S d;
+  throw 3;
+}
+
+int
+main ()
+{
+  try { foo (1); } catch (...) {}
+  if (d)
+    __builtin_abort ();
+}

diff --git a/gcc/tree-ssa-sink.c b/gcc/tree-ssa-sink.c
index eebff65cb4656219152ae9287929db39000dee86..dbf15290e9591cd53c340ca7139b9cf76e0c8f82 100644 (file)
--- a/gcc/tree-ssa-sink.c
+++ b/gcc/tree-ssa-sink.c
@@ -228,7 +228,7 @@ select_best_block (basic_block early_bb,
       /* If result of comparsion is unknown, prefer EARLY_BB.
         Thus use !(...>=..) rather than (...<...)  */
       && !(best_bb->count.apply_scale (100, 1)
-          > (early_bb->count.apply_scale (threshold, 1))))
+          >= early_bb->count.apply_scale (threshold, 1)))
     return best_bb;
 
   /* No better block found, so return EARLY_BB, which happens to be the