aco: fix block_kind_discard s_andn2 definition to exec
authorRhys Perry <pendingchaos02@gmail.com>
Mon, 18 Nov 2019 21:00:17 +0000 (21:00 +0000)
committerRhys Perry <pendingchaos02@gmail.com>
Mon, 2 Dec 2019 16:56:24 +0000 (16:56 +0000)
Improves generated code of dEQP-VK.graphicsfuzz.disc-and-add-in-func-in-loop
because a loop exit phi can then be fixed to exec, removing copies and
improving jump threading.

No pipeline-db changes.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
src/amd/compiler/aco_insert_exec_mask.cpp

index ba0d1f04a018c9e805cfc7a75826c10e1979c88b..31ae5ca658cf20f05fa93ca021b8d1dea21cee1a 100644 (file)
@@ -886,6 +886,8 @@ void add_branch_code(exec_ctx& ctx, Block* block)
       for (int i = num - 1; i >= 0; i--) {
          Instruction *andn2 = bld.sop2(aco_opcode::s_andn2_b64, bld.def(s2), bld.def(s1, scc),
                                        ctx.info[block->index].exec[i].first, cond);
+         if (i == (int)ctx.info[idx].exec.size() - 1)
+            andn2->definitions[0].setFixed(exec);
          if (i == 0)
             bld.pseudo(aco_opcode::p_exit_early_if, bld.scc(andn2->definitions[1].getTemp()));
          ctx.info[block->index].exec[i].first = andn2->definitions[0].getTemp();