Tweak warning output on Linux kernels with broken i386 NX support.
authorPedro Alves <palves@redhat.com>
Mon, 25 Feb 2013 17:32:06 +0000 (17:32 +0000)
committerPedro Alves <palves@redhat.com>
Mon, 25 Feb 2013 17:32:06 +0000 (17:32 +0000)
The "you have broken" bit of this text reads to me as if I had broken
it myself somehow.  This patch eliminates that ambiguity.

2013-02-25  Pedro Alves  <palves@redhat.com>

* common/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Change
warning text.

gdb/ChangeLog
gdb/common/linux-ptrace.c

index 6158d7286dc3689c0c849d06283cd0ffb8532ad7..a308ba81ead767d2b7fa1d5ddbde83633b44436d 100644 (file)
@@ -1,3 +1,8 @@
+2013-02-25  Pedro Alves  <palves@redhat.com>
+
+       * common/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Change
+       warning text.
+
 2013-02-24  Maciej W. Rozycki  <macro@codesourcery.com>
 
        * mips-tdep.c (mips32_scan_prologue): Reset frame_offset to zero
index 886be809d1d1aa46aa7ddf17bc2cac120051874c..e1001c6729031d48dbe424d01f4bb6fe856769c1 100644 (file)
@@ -224,8 +224,9 @@ linux_ptrace_test_ret_to_nx (void)
               "address %p nor is the return instruction %p!"),
             pc, return_address, &linux_ptrace_test_ret_to_nx_instr);
   else
-    warning (_("Cannot call inferior functions, you have broken "
-              "Linux kernel i386 NX (non-executable pages) support!"));
+    warning (_("Cannot call inferior functions on this system - "
+              "Linux kernel with broken i386 NX (non-executable pages) "
+              "support detected!"));
 #endif /* defined __i386__ || defined __x86_64__ */
 }