Fix segfault in relocate_erratum_stub on aarch64.

The fix for PR21868 (an internal error when --fix-cortex-a53-843419
is applied) has a small mistake in it. When the stub_owner section
needs an erratum fix an incorrect address for the stubs for the section
is given to relocate_erratum_stub. If we are lucky we will get a segfault;
if we aren't, an incorrect patch or data corruption is possible.
The error is visible in PR21868, but the side-effects aren't fatal.

gold/
	PR gold/22233
	* aarch64.cc (AArch64_relobj::fix_errata_and_relocate_erratum_stubs):
	Fix calculation of stub address.

diff --git a/gold/ChangeLog b/gold/ChangeLog
index b0014d3b4be257461cd66e982be0527feac09b37..49853f5ac125b205f467874ce3daafc52f44b6f8 100644 (file)
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,9 @@
+2017-11-30  Peter Smith  <peter.smith@linaro.org>
+
+       PR gold/22233
+       * aarch64.cc (AArch64_relobj::fix_errata_and_relocate_erratum_stubs):
+       Fix calculation of stub address.
+
 2017-11-29  Stefan Stroe  <stroestefan@gmail.com>
 
        * po/Make-in (datadir): Define as @datadir@.

diff --git a/gold/aarch64.cc b/gold/aarch64.cc
index 4c6e920f18a4a2914845d21d393c8521493bd57c..02fabb7749dc27b6179b0d288f100070c393db87 100644 (file)
--- a/gold/aarch64.cc
+++ b/gold/aarch64.cc
@@ -2041,7 +2041,7 @@ AArch64_relobj<size, big_endian>::fix_errata_and_relocate_erratum_stubs(
           // executed.
           stub_table->relocate_erratum_stub(
            stub,
-           pview.view + view_offset + (stub_table->address() - pview.address));
+           pview.view + (stub_table->address() - pview.address));
 
           // Next erratum stub.
          ++p;