* resres.c (probe_binary): Fix test for badly formatted headers.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 1d9a542b3485dcf9be106511ea86e299c84e81d3..f65bebba7120a50d9e37bed3a0363f3e3c222a13 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,7 @@
+2007-06-18  Thomas Weidenmueller  <w3seek@reactos.org>
+
+       * resres.c (probe_binary): Fix test for badly formatted headers.
+
 2007-06-18  Kai Tietz  <Kai.Tietz@onevision.com>
 
        * rclex.c: (cpp_line): Add code_page pragma support.

diff --git a/binutils/resres.c b/binutils/resres.c
index 8b75bcf59422cfe317e39b6a2da2c4b138809217..f345da3e5de6de9d3a36ca445ee9d5ae09d22978 100644 (file)
--- a/binutils/resres.c
+++ b/binutils/resres.c
@@ -554,10 +554,12 @@ read_unistring (windres_bfd *wrbfd, rc_uint_type *off, rc_uint_type omax,
   rc_uint_type l;
   rc_uint_type soff = off[0];
 
-  do {
-    read_res_data (wrbfd, &soff, omax, d, sizeof (unichar));
-    c = windres_get_16 (wrbfd, d, 2);
-  } while (c != 0);
+  do
+    {
+      read_res_data (wrbfd, &soff, omax, d, sizeof (unichar));
+      c = windres_get_16 (wrbfd, d, 2);
+    }
+  while (c != 0);
   l = ((soff - off[0]) / sizeof (unichar));
 
   /* there are hardly any names longer than 256 characters, but anyway. */
@@ -592,8 +594,11 @@ probe_binary (windres_bfd *wrbfd, rc_uint_type omax)
   if ((off + BIN_RES_HDR_SIZE) >= omax)
     return 1;
   read_res_data_hdr (wrbfd, &off, omax, &reshdr);
-  if ((off + reshdr.data_size + reshdr.header_size) > omax)
-      return 0;
+  /* off is advanced by BIN_RES_HDR_SIZE in read_res_data_hdr()
+     which is part of reshdr.header_size. We shouldn't take it
+     into account twice.  */
+  if ((off - BIN_RES_HDR_SIZE + reshdr.data_size + reshdr.header_size) > omax)
+    return 0;
   return 1;
 }