[Ada] ICE on renaming of result of binary operation

2018-07-17  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

	* gcc-interface/decl.c (gnat_to_gnu_entity) <E_Variable>: Deal with
	more rvalues in the expression of a renaming.

From-SVN: r262793

diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index 99ae0ea67b3463a2f9c8a1018e442c051852a030..ae2ab5dfce68be14a249401f1fc0a20680fde2dd 100644 (file)
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-17  Eric Botcazou  <ebotcazou@adacore.com>
+
+       * gcc-interface/decl.c (gnat_to_gnu_entity) <E_Variable>: Deal with
+       more rvalues in the expression of a renaming.
+
 2018-07-17  Eric Botcazou  <ebotcazou@adacore.com>
 
        * gcc-interface/ada-tree.h (TYPE_RETURN_BY_DIRECT_REF_P): Define for

diff --git a/gcc/ada/gcc-interface/decl.c b/gcc/ada/gcc-interface/decl.c
index 123fefb3131ca822533914882f6360511abbb799..50d20e6e8ea878b6832cacd99396189e987f5d89 100644 (file)
--- a/gcc/ada/gcc-interface/decl.c
+++ b/gcc/ada/gcc-interface/decl.c
@@ -969,8 +969,7 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
               function call is a constant object.  Therefore, it can be the
               inner object of a constant renaming and the renaming must be
               fully instantiated, i.e. it cannot be a reference to (part of)
-              an existing object.  And treat other rvalues (addresses, null
-              expressions, constructors and literals) the same way.  */
+              an existing object.  And treat other rvalues the same way.  */
            tree inner = gnu_expr;
            while (handled_component_p (inner) || CONVERT_EXPR_P (inner))
              inner = TREE_OPERAND (inner, 0);
@@ -981,11 +980,11 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
              inner = TREE_OPERAND (inner, 1);
            if ((TREE_CODE (inner) == CALL_EXPR
                 && !call_is_atomic_load (inner))
-               || TREE_CODE (inner) == ADDR_EXPR
-               || TREE_CODE (inner) == NULL_EXPR
-               || TREE_CODE (inner) == PLUS_EXPR
                || TREE_CODE (inner) == CONSTRUCTOR
                || CONSTANT_CLASS_P (inner)
+               || COMPARISON_CLASS_P (inner)
+               || BINARY_CLASS_P (inner)
+               || EXPRESSION_CLASS_P (inner)
                /* We need to detect the case where a temporary is created to
                   hold the return value, since we cannot safely rename it at
                   top level as it lives only in the elaboration routine.  */
@@ -1007,7 +1006,7 @@ gnat_to_gnu_entity (Entity_Id gnat_entity, tree gnu_expr, bool definition)
                   underlying object lives only in the elaboration routine.  */
                || (TREE_CODE (inner) == INDIRECT_REF
                    && (inner
-                         = remove_conversions (TREE_OPERAND (inner, 0), true))
+                       = remove_conversions (TREE_OPERAND (inner, 0), true))
                    && TREE_CODE (inner) == VAR_DECL
                    && DECL_RETURN_VALUE_P (inner)))
              ;