TextureStorage1D should return INVALID_OPERATION if target is not a 1D texture
authorIago Toral Quiroga <itoral@igalia.com>
Mon, 7 Aug 2017 04:18:24 +0000 (06:18 +0200)
committerIago Toral Quiroga <itoral@igalia.com>
Wed, 9 Aug 2017 07:28:33 +0000 (09:28 +0200)
Previous behavior was inconsistent with other texture targets so this has been
fixed in OpenGL 4.6.

Fixes:
KHR-GL45.direct_state_access.textures_storage_errors

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
src/mesa/main/texstorage.c

index e0930abe3f8cba330fb9a9e7f347fab185c2bfc9..44edba332357b279297fc0eced7b509657eab851 100644 (file)
@@ -605,7 +605,7 @@ texturestorage_error(GLuint dims, GLuint texture, GLsizei levels,
     * can receive unsized formats.
     */
    if (!legal_texobj_target(ctx, dims, texObj->Target)) {
-      _mesa_error(ctx, GL_INVALID_ENUM,
+      _mesa_error(ctx, GL_INVALID_OPERATION,
                   "%s(illegal target=%s)", caller,
                   _mesa_enum_to_string(texObj->Target));
       return;