vk/emit: Use valgrind to validate every packed field

diff --git a/src/vulkan/gen8_pack.h b/src/vulkan/gen8_pack.h
index aeb5dadd020697494a0ae06b4d4bee654123251b..54ad55ab490c070104e48542aacac0082ec65a45 100644 (file)
--- a/src/vulkan/gen8_pack.h
+++ b/src/vulkan/gen8_pack.h
@@ -32,6 +32,10 @@
 #include <stdio.h>
 #include <assert.h>
 
+#ifndef __gen_validate_value
+#define __gen_validate_value(x)
+#endif
+
 #ifndef __gen_field_functions
 #define __gen_field_functions
 
@@ -43,6 +47,7 @@ union __gen_value {
 static inline uint64_t
 __gen_field(uint64_t v, uint32_t start, uint32_t end)
 {
+   __gen_validate_value(v);
 #if DEBUG
    if (end - start + 1 < 64)
       assert(v < 1ul << (end - start + 1));
@@ -54,6 +59,7 @@ __gen_field(uint64_t v, uint32_t start, uint32_t end)
 static inline uint64_t
 __gen_offset(uint64_t v, uint32_t start, uint32_t end)
 {
+   __gen_validate_value(v);
 #if DEBUG
    uint64_t mask = (~0ul >> (64 - (end - start + 1))) << start;
 
@@ -66,6 +72,7 @@ __gen_offset(uint64_t v, uint32_t start, uint32_t end)
 static inline uint32_t
 __gen_float(float v)
 {
+   __gen_validate_value(v);
    return ((union __gen_value) { .f = (v) }).dw;
 }
 

diff --git a/src/vulkan/private.h b/src/vulkan/private.h
index 7ffba4f63b62950fbc04f8bc9bee26e4e22810fb..095f8f0f86eb0cbe88fab3334dfa7a19ff7a44e2 100644 (file)
--- a/src/vulkan/private.h
+++ b/src/vulkan/private.h
@@ -34,6 +34,7 @@
 #include <valgrind.h>
 #include <memcheck.h>
 #define VG(x) x
+#define __gen_validate_value(x) VALGRIND_CHECK_MEM_IS_DEFINED(&(x), sizeof(x))
 #else
 #define VG(x)
 #endif
@@ -488,7 +489,6 @@ __gen_combine_address(struct anv_batch *batch, void *location,
       };                                                                \
       void *__dst = anv_batch_emit_dwords(batch, cmd ## _length);       \
       cmd ## _pack(batch, __dst, &__template);                          \
-      VG(VALGRIND_CHECK_MEM_IS_DEFINED(__dst, (cmd ## _length) * 4));   \
    } while (0)
 
 #define anv_batch_emitn(batch, n, cmd, ...) ({          \