gitlab-ci: Fix traces caching in tracie
authorAlexandros Frantzis <alexandros.frantzis@collabora.com>
Tue, 24 Mar 2020 14:34:05 +0000 (16:34 +0200)
committerAlexandros Frantzis <alexandros.frantzis@collabora.com>
Thu, 26 Mar 2020 11:55:26 +0000 (13:55 +0200)
We are currently comparing a hex string representation of the git lfs
OID with a byte array representation of the locally calculated OID,
causing detection of valid cached traces to fail. Ensure we are
comparing compatible representations (in this case hex strings).

Signed-off-by: Alexandros Frantzis <alexandros.frantzis@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4300>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4300>

.gitlab-ci/tracie/tracie.py

index 445f566f2005ca8ef7eea3c3a323b7daebcaedca..388a73423bf0942757e251d31aae7404caa807ca 100644 (file)
@@ -86,7 +86,7 @@ def checksum(filename, hash_factory=hashlib.sha256, chunk_num_blocks=128):
     with open(filename,'rb') as f:
         for chunk in iter(lambda: f.read(chunk_num_blocks*h.block_size), b''):
             h.update(chunk)
-    return h.digest()
+    return h.hexdigest()
 
 def ensure_trace(repo_url, repo_commit, trace):
     trace_path = TRACES_DB_PATH + trace['path']