objc-act (objc_build_ivar_assignment): Do not call assemble_external.

	* objc-act (objc_build_ivar_assignment): Do not call assemble_external.
	(objc_build_global_assignment): Likewise.
	(objc_build_strong_cast_assignment): Likewise.
	* objc-next-runtime-abi-01.c: Cleanup commented-out assemble_external.
	* objc-next-runtime-abi-02.c: Likewise.
	* objc-gnu-runtime-abi-01.c: Likewise.

From-SVN: r185621

diff --git a/gcc/objc/ChangeLog b/gcc/objc/ChangeLog
index 709121416605e46c77e9142746b53d0e53d0197a..32f7b1af720091d2fb9496c4b0fa95e3a8a7efb2 100644 (file)
--- a/gcc/objc/ChangeLog
+++ b/gcc/objc/ChangeLog
@@ -1,3 +1,12 @@
+2012-03-21  Steven Bosscher  <steven@gcc.gnu.org>
+
+       * objc-act (objc_build_ivar_assignment): Do not call assemble_external.
+       (objc_build_global_assignment): Likewise.
+       (objc_build_strong_cast_assignment): Likewise.
+       * objc-next-runtime-abi-01.c: Cleanup commented-out assemble_external.
+       * objc-next-runtime-abi-02.c: Likewise.
+       * objc-gnu-runtime-abi-01.c: Likewise.
+
 2012-03-05  Jason Merrill  <jason@redhat.com>
 
        * objc-map.c (objc_map_private_resize, objc_map_alloc_ggc): Don't

diff --git a/gcc/objc/objc-act.c b/gcc/objc/objc-act.c
index 4a024f419a7b2e4006e2c694a0220c168b617a3c..78a3cee4abe1022d7933a2df7bc66f396d71f8eb 100644 (file)
--- a/gcc/objc/objc-act.c
+++ b/gcc/objc/objc-act.c
@@ -3553,7 +3553,6 @@ objc_build_ivar_assignment (tree outervar, tree lhs, tree rhs)
                tree_cons (NULL_TREE, offs,
                    NULL_TREE)));
 
-  assemble_external (func);
   return build_function_call (input_location, func, func_params);
 }
 
@@ -3566,7 +3565,6 @@ objc_build_global_assignment (tree lhs, tree rhs)
                      build_unary_op (input_location, ADDR_EXPR, lhs, 0)),
                    NULL_TREE));
 
-  assemble_external (objc_assign_global_decl);
   return build_function_call (input_location,
                              objc_assign_global_decl, func_params);
 }
@@ -3580,7 +3578,6 @@ objc_build_strong_cast_assignment (tree lhs, tree rhs)
                      build_unary_op (input_location, ADDR_EXPR, lhs, 0)),
                    NULL_TREE));
 
-  assemble_external (objc_assign_strong_cast_decl);
   return build_function_call (input_location,
                              objc_assign_strong_cast_decl, func_params);
 }

diff --git a/gcc/objc/objc-gnu-runtime-abi-01.c b/gcc/objc/objc-gnu-runtime-abi-01.c
index f136828f60acb586250f1d6868dafbff30ab946f..63a8c5b2e31b421f6c2e9f91475ffdc06f8b58f4 100644 (file)
--- a/gcc/objc/objc-gnu-runtime-abi-01.c
+++ b/gcc/objc/objc-gnu-runtime-abi-01.c
@@ -574,8 +574,6 @@ gnu_runtime_abi_01_get_class_reference (tree ident)
                                                (IDENTIFIER_LENGTH (ident) + 1,
                                                 IDENTIFIER_POINTER (ident)));
 
-  /* FIXME: Do we need this assemble_external() ? */
-  /* assemble_external (objc_get_class_decl);*/
   return build_function_call (input_location, objc_get_class_decl, params);
 }
 
@@ -839,8 +837,6 @@ gnu_runtime_abi_01_get_category_super_ref (location_t loc ATTRIBUTE_UNUSED,
 
   add_class_reference (super_name);
   super_class = (inst_meth ? objc_get_class_decl : objc_get_meta_class_decl);
-  /* FIXME: Do we need this assemble_external() ? */
-  /* assemble_external (super_class);*/
   super_name = my_build_string_pointer (IDENTIFIER_LENGTH (super_name) + 1,
                                        IDENTIFIER_POINTER (super_name));
   /* super_class = get_{meta_}class("CLASS_SUPER_NAME");  */

diff --git a/gcc/objc/objc-next-runtime-abi-01.c b/gcc/objc/objc-next-runtime-abi-01.c
index 7d6a21256322591b7d5400ceef5a58805d6bcb1c..a3ca8fcd7011ceff894780800aa23f2c7e02e28d 100644 (file)
--- a/gcc/objc/objc-next-runtime-abi-01.c
+++ b/gcc/objc/objc-next-runtime-abi-01.c
@@ -977,7 +977,6 @@ next_runtime_abi_01_get_category_super_ref (location_t loc ATTRIBUTE_UNUSED,
   /* else do it the slow way.  */
   add_class_reference (super_name);
   super_class = (inst_meth ? objc_get_class_decl : objc_get_meta_class_decl);
-/* assemble_external (super_class);*/
   super_name = my_build_string_pointer (IDENTIFIER_LENGTH (super_name) + 1,
                                        IDENTIFIER_POINTER (super_name));
   /* super_class = objc_get{Meta}Class("CLASS_SUPER_NAME"); */

diff --git a/gcc/objc/objc-next-runtime-abi-02.c b/gcc/objc/objc-next-runtime-abi-02.c
index 4512c846cc0c0e74611ccbe0cdb982e3d594a2b3..ee6a0a3fbf739f6958b0a86e45de05a1a4b31d0c 100644 (file)
--- a/gcc/objc/objc-next-runtime-abi-02.c
+++ b/gcc/objc/objc-next-runtime-abi-02.c
@@ -1509,7 +1509,6 @@ next_runtime_abi_02_get_category_super_ref (location_t loc ATTRIBUTE_UNUSED,
   /* ??? Do we need to add the class ref anway for zero-link?  */
   /* else do it the slow way.  */
   super_class = (inst_meth ? objc_get_class_decl : objc_get_meta_class_decl);
-  /* assemble_external (super_class); */
   super_name = my_build_string_pointer (IDENTIFIER_LENGTH (super_name) + 1,
                                        IDENTIFIER_POINTER (super_name));
   /* super_class = objc_get{Meta}Class("CLASS_SUPER_NAME"); */