x86: Replace "is not" with "!=" in fpop.isa.
authorGabe Black <gabeblack@google.com>
Mon, 24 Aug 2020 10:16:08 +0000 (03:16 -0700)
committerGabe Black <gabeblack@google.com>
Tue, 25 Aug 2020 06:24:49 +0000 (06:24 +0000)
Some variables were being compared against some constants with "is not",
which is not correct since it will compare for identity rather than
equivalence. There was a long standing build warning from this, but it
wasn't clear where the error was coming from since it was in python
interpreted from a string in the ISA description.

This change replaces "is not" in those two places with "!=".

Change-Id: I0c4d038af6e047ffd79f8171713e8e998e840e3b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/33283
Maintainer: Gabe Black <gabeblack@google.com>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
src/arch/x86/isa/microops/fpop.isa

index a4a1374313456f5df56c22cf727fa3ed77f09b08..e5b15c1fc60e2d735666381973e432a79268b4ff 100644 (file)
@@ -123,7 +123,7 @@ let {{
 
             # If there's something optional to do with flags, generate
             # a version without it and fix up this version to use it.
-            if flag_code is not "" or cond_check is not "true":
+            if flag_code != "" or cond_check != "true":
                 self.buildCppClasses(name, Name, suffix,
                         code, "", "true", else_code, op_class)
                 suffix = "Flags" + suffix