r600g/sb: Update last_cf for loops
authorGlenn Kennard <glenn.kennard@gmail.com>
Thu, 26 Mar 2015 01:56:50 +0000 (02:56 +0100)
committerDave Airlie <airlied@redhat.com>
Tue, 7 Apr 2015 22:18:17 +0000 (08:18 +1000)
CF_END could end up emitted in the middle of a shader on cayman
when there was a loop at the very end.

Fixes glsl-1.50-geometry-end-primitive and
ext_transform_feedback-geometry-shaders-basic piglit tests.

Signed-off-by: Glenn Kennard <glenn.kennard@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
src/gallium/drivers/r600/sb/sb_bc_finalize.cpp

index 8d0be06802cc63a844c8f9da88d122b3985d98a5..08b7d77f1a40fb2cc5b26f60bff33141b90f9ac4 100644 (file)
@@ -127,6 +127,14 @@ void bc_finalizer::finalize_loop(region_node* r) {
        cf_node *loop_start = sh.create_cf(CF_OP_LOOP_START_DX10);
        cf_node *loop_end = sh.create_cf(CF_OP_LOOP_END);
 
+       // Update last_cf, but don't overwrite it if it's outside the current loop nest since
+       // it may point to a cf that is later in program order.
+       // The single parent level check is sufficient since finalize_loop() is processed in
+       // reverse order from innermost to outermost loop nest level.
+       if (!last_cf || last_cf->get_parent_region() == r) {
+               last_cf = loop_end;
+       }
+
        loop_start->jump_after(loop_end);
        loop_end->jump_after(loop_start);