package/gtkmm3: reorder select/depends
authorRomain Naour <romain.naour@openwide.fr>
Mon, 28 Dec 2015 21:23:33 +0000 (22:23 +0100)
committerThomas Petazzoni <thomas.petazzoni@free-electrons.com>
Mon, 28 Dec 2015 21:31:45 +0000 (22:31 +0100)
>From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."

Also, the Config.in exemple in the manual suggest to use this coding
style [2].

[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
package/gtkmm3/Config.in

index 30d3492cfc85c890112c2f71f347a4c5faf85c54..f617d838795b5eee2fdffcfd9c216d70fc9ac98a 100644 (file)
@@ -1,17 +1,17 @@
 config BR2_PACKAGE_GTKMM3
        bool "gtkmm3"
-       select BR2_PACKAGE_ATKMM
-       select BR2_PACKAGE_CAIROMM
-       select BR2_PACKAGE_GLIBMM
-       select BR2_PACKAGE_LIBGTK3
-       select BR2_PACKAGE_LIBSIGC
-       select BR2_PACKAGE_PANGOMM
        depends on BR2_ARCH_HAS_ATOMICS # libcairomm/libgtk3/libpangomm -> cairo
        depends on BR2_INSTALL_LIBSTDCPP # glibmm, libpangomm -> glibmm/pango
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
        depends on BR2_TOOLCHAIN_HAS_THREADS # *mm/libgtk3 -> libglib2
        depends on BR2_USE_MMU # *mm/libgtk3 -> libglib2
        depends on BR2_USE_WCHAR # *mm/libgtk3 -> libglib2
+       select BR2_PACKAGE_ATKMM
+       select BR2_PACKAGE_CAIROMM
+       select BR2_PACKAGE_GLIBMM
+       select BR2_PACKAGE_LIBGTK3
+       select BR2_PACKAGE_LIBSIGC
+       select BR2_PACKAGE_PANGOMM
        help
          The gtkmm3 package is a set of C++ bindings for GTK 3.