gas:

2003-08-06  Jason Eckhardt  <jle@rice.edu>

        * config/tc-i860.c (i860_process_insn): Check that instructions
        with their dual-bit set are 8-byte aligned.

gas/testsuite:
2003-08-06  Jason Eckhardt  <jle@rice.edu>

        * gas/i860/dual02-err.l: Update expected error message.
        * gas/i860/README.i860: Remove dual02-err from known failure list.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 7bf5fcd06fa98a16769e1512c67ab46255e009f7..8e1356c074bbdd698dafa1bab778bdbf9222476c 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2003-08-06  Jason Eckhardt  <jle@rice.edu>
+
+       * config/tc-i860.c (i860_process_insn): Check that instructions
+       with their dual-bit set are 8-byte aligned.
+
 2003-08-06  Nick Clifton  <nickc@redhat.com>
 
        * po/fr.po: Updated French translation.

diff --git a/gas/config/tc-i860.c b/gas/config/tc-i860.c
index 37aff49efa41261a76a16b3dcdc4141734daf267..d170b7047c3e8b1dbab2e788996e4897e6076d05 100644 (file)
--- a/gas/config/tc-i860.c
+++ b/gas/config/tc-i860.c
@@ -933,7 +933,13 @@ i860_process_insn (char *str)
     {
       if ((opcode & 0xfc000000) == 0x48000000 || opcode == 0xb0000000)
         {
-         opcode |= (1 << 9);
+         /* The instruction is a flop or a fnop, so set its dual bit
+            (but check that it is 8-byte aligned).  */
+         if (((frag_now->fr_address + frag_now_fix_octets ()) & 7) == 0)
+           opcode |= (1 << 9);
+         else
+            as_bad (_("'d.%s' must be 8-byte aligned"), insn->name);
+
           if (dual_mode == DUAL_DDOT)
            dual_mode = DUAL_OFF;
           else if (dual_mode == DUAL_ONDDOT)

diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 3176e6f511980112e65ea9c84eadee1e7825bc49..30591b72283656c872f8ffac199b35082dc0ef31 100644 (file)
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2003-08-06  Jason Eckhardt  <jle@rice.edu>
+
+       * gas/i860/dual02-err.l: Update expected error message.
+       * gas/i860/README.i860: Remove dual02-err from known failure list.
+
 2003-08-05  Jason Eckhardt  <jle@rice.edu>
 
        * gas/i860/README.i860: Remove dual01 from the known failures.

diff --git a/gas/testsuite/gas/i860/README.i860 b/gas/testsuite/gas/i860/README.i860
index e7b07446756dad05a4719a721aa0b85a599e3afc..ae5c89062c098a17d427b02019a1b580cd24b782 100644 (file)
--- a/gas/testsuite/gas/i860/README.i860
+++ b/gas/testsuite/gas/i860/README.i860
@@ -25,10 +25,12 @@ TODO:
    tests of the Intel syntax should be added to prevent bitrot (including
    relocatable expression syntax, etc).  Test file dual03.s uses Intel
    syntax lightly (i.e., register names without '%' prefix).
+ - Currently, .align in a .text section fills with 0x00000000.  This is
+   a defect and it needs to fill with nop (0xa0000000).  Write a testcase
+   for it.
 
 Contact me (Jason Eckhardt, jle@rice.edu) if you'd like to help.
 
 Known testsuite failures:
-  - dual02-err.s: GAS currently doesn't check that dual mode pairs
-      are properly aligned.
+  - none.
 

diff --git a/gas/testsuite/gas/i860/dual02-err.l b/gas/testsuite/gas/i860/dual02-err.l
index f8f1a1d8eb9467730e00f0caa0b96536dde0878d..d43d73e46a39bcb6d1a114cda1cb8d1f8be6f1bd 100644 (file)
--- a/gas/testsuite/gas/i860/dual02-err.l
+++ b/gas/testsuite/gas/i860/dual02-err.l
@@ -1,2 +1,2 @@
 .*: Assembler messages:
-.*:7: Error: FLOP with 'd\.' prefix must be 8-byte aligned
+.*:7: Error: 'd\.fadd\.ss' must be 8-byte aligned