Emit a note warning the user that creating an executable stack because of a missing...

	PR 29072
bfd	* elflink.c (bfd_elf_size_dynamic_sections): Display a note to the
	user that the current ehaviour of creating an executable stack
	because of a missing .note.GNU-stack section is deprecated and
	will be changed in a future release.

binutils* testsuite/lib/binutils-common.exp (prune_warnings_extra): Filter
	out notes about the executable stacjk behaviour beign deprecated.

ld	* testsuite/ld-elf/pr29072.b.warn: Update to include the note
	about the linker's behaviour being depreccated.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 957d8fd556c024de34c1815c023893956ad3b598..5444381ede01e0cfaedd236d8a738ee02232025d 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,11 @@
+2022-04-25  Nick Clifton  <nickc@redhat.com>
+
+       PR 29072
+       * elflink.c (bfd_elf_size_dynamic_sections): Display a note to the
+       user that the current ehaviour of creating an executable stack
+       because of a missing .note.GNU-stack section is deprecated and
+       will be changed in a future release.
+
 2022-04-20  Clément Chigot  <clement.chigot@atos.net>
 
        * coff-rs6000.c (xcoff_reloc_type_noop): Add info argument.

diff --git a/bfd/elflink.c b/bfd/elflink.c
index d6dd9c16a26718f1e1b82fea2bb0cfd1ff47a4b9..b54ee517c754f51482818c1aeec1f60b5bb32ce7 100644 (file)
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -7190,9 +7190,13 @@ warning: enabling an executable stack because of -z execstack command line optio
 warning: %s: requires executable stack (because the .note.GNU-stack section is executable)"),
                       bfd_get_filename (noteobj));
                  else if (emptyobj)
-                   _bfd_error_handler (_("\
+                   {
+                     _bfd_error_handler (_("\
 warning: %s: missing .note.GNU-stack section implies executable stack"),
-                      bfd_get_filename (emptyobj));
+                                         bfd_get_filename (emptyobj));
+                     _bfd_error_handler (_("\
+NOTE: This behaviour is deprecated and will be removed in a future version of the linker"));
+                   }
                }
            }
          elf_stack_flags (output_bfd) = PF_R | PF_W | exec;

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 26103a0279d2ee8c1e433c61b25609fe53555290..ab65d20aca1912f74ec78e4a489f5c072ecc95db 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2022-04-25  Nick Clifton  <nickc@redhat.com>
+
+       PR 29072
+       * testsuite/lib/binutils-common.exp (prune_warnings_extra): Filter
+       out notes about the executable stacjk behaviour beign deprecated.
+
 2022-04-12  Nick Clifton  <nickc@redhat.com>
 
        PR 28992

diff --git a/binutils/testsuite/lib/binutils-common.exp b/binutils/testsuite/lib/binutils-common.exp
index 87b0d101c6c1a2226b94ab948d8fa73c92acfa35..a76a310c199b919f0fb683371e16648e587716cf 100644 (file)
--- a/binutils/testsuite/lib/binutils-common.exp
+++ b/binutils/testsuite/lib/binutils-common.exp
@@ -638,6 +638,7 @@ proc prune_warnings_extra { text } {
     # PR binutils/23898: It is OK to have gaps in build notes.
     regsub -all "(^|\n)(\[^\n\]*: Warning: Gap in build notes detected from\[^\n\]*\n?)+" $text "\\1" text
     regsub -all "(^|\n)(\[^\n\]*: warning:\[^\n\]*missing \\.note\\.GNU-stack section\[^\n\]*\n?)+" $text "\\1" text
+    regsub -all "(^|\n)(\[^\n\]*: NOTE: This behaviour is deprecated\[^\n\]*\n?)+" $text "\\1" text
     return $text
 }
 

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 86ac875c4d137ea8e8b822d7e5ffb20d2c7ad82d..456c11883acf51da30c7b91987383e72fcdaf612 100644 (file)
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2022-04-25  Nick Clifton  <nickc@redhat.com>
+
+       PR 29072
+       * testsuite/ld-elf/pr29072.b.warn: Update to include the note
+       about the linker's behaviour being depreccated.
+
 2022-04-20  Clément Chigot  <clement.chigot@atos.net>
 
        * emultempl/aix.em (params): New variable.

diff --git a/ld/testsuite/ld-elf/pr29072.b.warn b/ld/testsuite/ld-elf/pr29072.b.warn
index 08f11887921ec97b3cded0c2122af39c2c515d71..9058cc0e68b05216c84da7be4493ae0164fe771a 100644 (file)
--- a/ld/testsuite/ld-elf/pr29072.b.warn
+++ b/ld/testsuite/ld-elf/pr29072.b.warn
@@ -1 +1,2 @@
 .*: warning: .*\.o: missing \.note\.GNU-stack section implies executable stack
+.*: NOTE: This behaviour is deprecated and will be removed in a future version of the linker