Fix Windows gdb build failure with Python 2 support

GDB fails to build for Windows host with Python 2 support enabled due
to PyFile_FromString's second argument being of type char * and being
passed a (const) string literal. This parameter is input only so this
commit fixes the issue by casting to char *.

2017-04-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>

gdb/
	* python/python.c (python_run_simple_file): Cast mode literal to
	non-const char pointer as expected by PyFile_FromString.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 880af5b8c93dfd231ad627eb0f68e4a11dadf68c..e906b870c5ccb58dacd2032011359fb95311533e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-04-06  Thomas Preud'homme  <thomas.preudhomme@arm.com>
+
+       * python/python.c (python_run_simple_file): Cast mode literal to
+       non-const char pointer as expected by PyFile_FromString.
+
 2017-04-05  Simon Marchi  <simon.marchi@ericsson.com>
 
        * common/ptid.c (ptid_lwp_p, ptid_tid_p): Remove comparison with

diff --git a/gdb/python/python.c b/gdb/python/python.c
index cc58267b9557a9d6893f03b99d7912b5a3affdbb..e0e24acac41db6085d7ac906cb9122eacd6fd6cd 100644 (file)
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -352,7 +352,7 @@ python_run_simple_file (FILE *file, const char *filename)
   /* Because we have a string for a filename, and are using Python to
      open the file, we need to expand any tilde in the path first.  */
   gdb::unique_xmalloc_ptr<char> full_path (tilde_expand (filename));
-  gdbpy_ref<> python_file (PyFile_FromString (full_path.get (), "r"));
+  gdbpy_ref<> python_file (PyFile_FromString (full_path.get (), (char *) "r"));
   if (python_file == NULL)
     {
       gdbpy_print_stack ();