gdb/

	* infcall.c (call_function_by_hand): Remove gdb_assert on sp and old_sp.
	New comment.

gdb/testsuite/
	* gdb.base/callfuncs.exp: New tests for $spval 0 and -1.  Remove return.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 38792a65f0545584bd7ee044d22e4d3c8fcf247d..56f16d50a41344dae7991663ab5e89b3d3697067 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2010-02-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+       * infcall.c (call_function_by_hand): Remove gdb_assert on sp and old_sp.
+       New comment.
+
 2010-02-28  Corinna Vinschen  <vinschen@redhat.com>
 
        * Makefile.in (SUBDIR_MI_OBS): Move mi-common.o from here...

diff --git a/gdb/infcall.c b/gdb/infcall.c
index e64289414836d7b74616631426da37af173ce8fa..2d8bd2cecade786a4cb900d26729196ee27d8099 100644 (file)
--- a/gdb/infcall.c
+++ b/gdb/infcall.c
@@ -518,10 +518,9 @@ call_function_by_hand (struct value *function, int nargs, struct value **args)
              /* Stack grows up.  */
              sp = gdbarch_frame_align (gdbarch, old_sp + 1);
          }
-       gdb_assert ((gdbarch_inner_than (gdbarch, 1, 2)
-                   && sp <= old_sp)
-                   || (gdbarch_inner_than (gdbarch, 2, 1)
-                      && sp >= old_sp));
+       /* SP may have underflown address zero here from OLD_SP.  Memory access
+          functions will probably fail in such case but that is a target's
+          problem.  */
       }
     else
       /* FIXME: cagney/2002-09-18: Hey, you loose!

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index ebc5edb9372f64a7552f4a669c33487971e9483f..8684ebc67d4d9708c2ed22dd53928cf92a557b7d 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-02-28  Jan Kratochvil  <jan.kratochvil@redhat.com>
+           Daniel Jacobowitz  <dan@codesourcery.com>
+
+       * gdb.base/callfuncs.exp: New tests for $spval 0 and -1.  Remove return.
+
 2010-02-25  David S. Miller  <davem@davemloft.net>
 
        * gdb.base/catch-syscall.exp: Allow to run on sparc*-*-linux and

diff --git a/gdb/testsuite/gdb.base/callfuncs.exp b/gdb/testsuite/gdb.base/callfuncs.exp
index 46ba509524697edbaf5f2893f1a0a5734a6176a2..9aeb09be3ed1e0fbcfc71b35ce41dcd18e28b3da 100644 (file)
--- a/gdb/testsuite/gdb.base/callfuncs.exp
+++ b/gdb/testsuite/gdb.base/callfuncs.exp
@@ -469,5 +469,17 @@ if {$old_reg_content == $new_reg_content} then {
     fail "nested call dummies preserve register contents"
 }
 
-return 0
+# GDB should not crash by internal error on $sp underflow during the inferior
+# call.  It is OK it will stop on some: Cannot access memory at address 0x$hex.
 
+if {![target_info exists gdb,nosignals] && ![istarget "*-*-uclinux*"]} {
+    gdb_test {set $old_sp = $sp}
+
+    gdb_test {set $sp = 0}
+    gdb_test "call doubleit (1)" "" "sp == 0: call doubleit (1)"
+
+    gdb_test {set $sp = -1}
+    gdb_test "call doubleit (1)" "" "sp == -1: call doubleit (1)"
+
+    gdb_test {set $sp = $old_sp}
+}