Make the strings utility reject directories.

	PR binutils/21659
	* strings.c (strings_file): Warn about attempts to run strings on
	a directory.

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 484632addb5679a160ab587fee362f919fc4305e..b4672fa50c576311252b6aff053ea9e6fc8297b8 100644 (file)
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2017-06-23  Nick Clifton  <nickc@redhat.com>
+
+       PR binutils/21659
+       * strings.c (strings_file): Warn about attempts to run strings on
+       a directory.
+
 2017-06-22  H.J. Lu  <hongjiu.lu@intel.com>
 
        * readelf.c (decode_x86_feature): Decode

diff --git a/binutils/strings.c b/binutils/strings.c
index 13e261923b8876e480010b97eb37a7d46c2811b5..77d89eb98125591208e6e6e7d52891bbbb80128a 100644 (file)
--- a/binutils/strings.c
+++ b/binutils/strings.c
@@ -446,6 +446,11 @@ strings_file (char *file)
                   file, strerror (errno));
       return FALSE;
     }
+  else if (S_ISDIR (st.st_mode))
+    {
+      non_fatal (_("Warning: '%s' is a directory"), file);
+      return FALSE;
+    }
 
   /* If we weren't told to scan the whole file,
      try to open it as an object file and only look at