re PR middle-end/14327 (-O0 -fdefer-pop generates wrong code)

        PR middle-end/14327
        * stmt.c (expand_computed_goto): Do do_pending_stack_adjust before
        emitting the label, not after.
	* gcc.c-torture/execute/20040302-1.c: New.

From-SVN: r78798

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 8bc1d5a0e0336b00c80f73a726b8d9dfe9246aee..1a8e3331442a2e07b752fc91c4660404886eb8e5 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2004-03-02  Richard Henderson  <rth@redhat.com>
+
+       PR middle-end/14327
+       * stmt.c (expand_computed_goto): Do do_pending_stack_adjust before
+       emitting the label, not after.
+
 2004-03-02  Stephane Carrez  <stcarrez@nerim.fr>
 
        * config/m68hc11/m68hc11.c (m68hc11_addr_mode): New variable.

diff --git a/gcc/stmt.c b/gcc/stmt.c
index b3b1f1b5b6bb0127b123060a285a7fcdd19ddfc2..092720fb52b2b9fb034fa0d1af38fd218ae383e1 100644 (file)
--- a/gcc/stmt.c
+++ b/gcc/stmt.c
@@ -524,9 +524,9 @@ expand_computed_goto (tree exp)
     {
       cfun->computed_goto_common_reg = copy_to_mode_reg (Pmode, x);
       cfun->computed_goto_common_label = gen_label_rtx ();
-      emit_label (cfun->computed_goto_common_label);
 
       do_pending_stack_adjust ();
+      emit_label (cfun->computed_goto_common_label);
       emit_indirect_jump (cfun->computed_goto_common_reg);
 
       current_function_has_computed_jump = 1;

diff --git a/gcc/testsuite/gcc.c-torture/execute/20040302-1.c b/gcc/testsuite/gcc.c-torture/execute/20040302-1.c
new file mode 100644 (file)
index 0000000..07056c4
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/execute/20040302-1.c
@@ -0,0 +1,24 @@
+int code[]={0,0,0,0,1};
+
+void foo(int x) {
+  volatile int b;
+  b = 0xffffffff;
+}
+
+void bar(int *pc) {
+  static const void *l[] = {&&lab0, &&end};
+
+  foo(0);
+  goto *l[*pc];
+ lab0:
+  foo(0);
+  pc++;
+  goto *l[*pc];
+ end:
+  return;
+}
+
+int main() {
+  bar(code);
+  return 0;
+}