re PR tree-optimization/71423 (wrong code at -Os and above on x86_64-linux-gnu)

2016-06-07  Richard Biener  <rguenther@suse.de>

	PR middle-end/71423
	* match.pd ((X | ~Y) -> Y <= X): Properly invert the comparison
	for signed ops.

	* gcc.dg/torture/pr71423.c: New testcase.

From-SVN: r237166

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index edc45f5f8e9e9ee6a5b1f4da310cffc1deb5b935..878ee3a5f2ecbed5165295fa6547a9b071d1e245 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2016-06-07  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/71423
+       * match.pd ((X | ~Y) -> Y <= X): Properly invert the comparison
+       for signed ops.
+
 2016-06-06  John David Anglin  <danglin@gcc.gnu.org>
 
        * config/pa/pa.md (call): Generate indirect long calls to non-local

diff --git a/gcc/match.pd b/gcc/match.pd
index 4d66243d78e7881364594f93779f6041ce367be3..fe711159df9dd6456c61da67599345cb664c5ed6 100644 (file)
--- a/gcc/match.pd
+++ b/gcc/match.pd
@@ -900,12 +900,16 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT)
   (ne (bit_and:c (bit_not @0) @1) integer_zerop)
   (if (INTEGRAL_TYPE_P (TREE_TYPE (@1))
        && TYPE_PRECISION (TREE_TYPE (@1)) == 1)
-   (lt @0 @1)))
+   (if (TYPE_UNSIGNED (TREE_TYPE (@1)))
+    (lt @0 @1)
+    (gt @0 @1))))
 (simplify
   (ne (bit_ior:c (bit_not @0) @1) integer_zerop)
   (if (INTEGRAL_TYPE_P (TREE_TYPE (@1))
        && TYPE_PRECISION (TREE_TYPE (@1)) == 1)
-   (le @0 @1)))
+   (if (TYPE_UNSIGNED (TREE_TYPE (@1)))
+    (le @0 @1)
+    (ge @0 @1))))
 
 /* ~~x -> x */
 (simplify

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a1a7f1994ffe48b028621ec202e50e857401d112..52bb629e4e7787bd0774c40bcbab6a7c0c5ca54b 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-06-07  Richard Biener  <rguenther@suse.de>
+
+       PR middle-end/71423
+       * gcc.dg/torture/pr71423.c: New testcase.
+
 2016-06-07  Kugan Vivekanandarajah  <kuganv@linaro.org>
 
        PR middle-end/71408

diff --git a/gcc/testsuite/gcc.dg/torture/pr71423.c b/gcc/testsuite/gcc.dg/torture/pr71423.c
new file mode 100644 (file)
index 0000000..06a613f
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr71423.c
@@ -0,0 +1,20 @@
+/* { dg-do run } */
+
+struct S1
+{
+  int f1:1;
+};
+
+volatile struct S1 b = { 0 };
+
+int
+main ()
+{
+  char c = b.f1;
+  b.f1 = 1; 
+
+  if (b.f1 > -1 || c)
+    __builtin_abort (); 
+
+  return 0; 
+}