COFF linker segmentation faults

A plugin can change the element, so call the generic
bfd_link_add_symbols.

	PR 24596
	* cofflink.c (coff_link_check_archive_element): Don't assume
	element is a coff object file after calling add_archive_element.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 464203fa62935add4f415128a2732038bd5757e4..09ba27afd4439bddeeea729290a7aea764486833 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2019-05-28  Alan Modra  <amodra@gmail.com>
+
+       PR 24596
+       * cofflink.c (coff_link_check_archive_element): Don't assume
+       element is a coff object file after calling add_archive_element.
+
 2019-05-28  Alan Modra  <amodra@gmail.com>
 
        PR 24596

diff --git a/bfd/cofflink.c b/bfd/cofflink.c
index ac07d05e5789812fec774aa6bf8cbe0941c5dfcf..5e02760154306e6a51093ef8a31f21217861a60d 100644 (file)
--- a/bfd/cofflink.c
+++ b/bfd/cofflink.c
@@ -221,7 +221,7 @@ coff_link_check_archive_element (bfd *abfd,
     return TRUE;
   *pneeded = TRUE;
 
-  return coff_link_add_object_symbols (abfd, info);
+  return bfd_link_add_symbols (abfd, info);
 }
 
 /* Add all the symbols from an object file to the hash table.  */