* tracepoint.c (tfile_open): Remove spurious discard_cleanups.

	Merge uploaded TSVs before merging uploaded tracepoints.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ddf66153dbfa05fa72ecb294056db0e1060a82d3..a679110dbeaeddcab7756b27670d76c5d48e3a07 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2010-02-11  Pedro Alves  <pedro@codesourcery.com>
+
+       * tracepoint.c (tfile_open): Remove spurious discard_cleanups.
+       Merge uploaded TSVs before merging uploaded tracepoints.
+
 2010-02-11  Pedro Alves  <pedro@codesourcery.com>
 
        * ax-gdb.c (gen_deref): Don't allow dereferencing void pointers.

diff --git a/gdb/tracepoint.c b/gdb/tracepoint.c
index 73fd547d6cdb01602a0e9abba18507ba04bdf526..e27b6905a18e71afae48d012646c57028789c4e7 100644 (file)
--- a/gdb/tracepoint.c
+++ b/gdb/tracepoint.c
@@ -2824,7 +2824,6 @@ tfile_open (char *filename, int from_tty)
   unpush_target (&tfile_ops);
 
   push_target (&tfile_ops);
-  discard_cleanups (old_chain);
 
   trace_filename = xstrdup (filename);
   trace_fd = scratch_chan;
@@ -2881,10 +2880,12 @@ tfile_open (char *filename, int from_tty)
 
   /* Add the file's tracepoints and variables into the current mix.  */
 
-  merge_uploaded_tracepoints (&uploaded_tps);
-
+  /* Get trace state variables first, they may be checked when parsing
+     uploaded commands.  */
   merge_uploaded_trace_state_variables (&uploaded_tsvs);
 
+  merge_uploaded_tracepoints (&uploaded_tps);
+
   /* Record the starting offset of the binary trace data.  */
   trace_frames_offset = bytes;