thread support broken on ppc-aix.

Thread support got broken when adding 64bit support on ppc-aix.
Upon digging further, I found that the following patch...

   | * gdb_ptrace.h: Use ptrace64 instead of ptrace if HAVE_PTRACE64
   | is defined.
   | * rs6000-nat.c: Check for __ld_info64_ if compiling 64 BIT gdb.
   | (rs6000_ptrace32): Call ptrace64 instead of ptrace if present.
   | (rs6000_ptrace64): Call ptace64 instead of ptracex if present.
   | * configure.ac: Check for ptrace64.
   | * configure, config.in: Regenerate.

... is responsible for this regression:

    (gdb) x /x &__n_pthreads
    0xf06a8258 <__n_pthreads>: Cannot access memory at address 0xf06a8258

Prior to the patch, we have:

    (gdb) x /x &__n_pthreads
    0xf06a8258 <__n_pthreads>: 0x00000003

The problem occurs inside rs6000_ptrace32, while calling ptrace64.
The address is given to rs6000_ptrace32 as an "int *", while
ptrace64 takes a "long long". The cast causes the address to be
sign-extended, which results in GDB trying to read the wrong address.

This patch fixes the issue by casting the address to a "uintptr_t"
instead, and letting the compiler do the implicit conversion to
"long long" in the function call.

gdb/ChangeLog:

        * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
        instead of "long long" in call to ptrace64.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7c2647e31765372bc4d53a6ba200826eca4258de..f676c3f3eaad4221e2b6a23045d167a9d1a240b1 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-08-29  Joel Brobecker  <brobecker@adacore.com>
+
+       * rs6000-nat.c (rs6000_ptrace32): Cast "addr" to "uintptr_t"
+       instead of "long long" in call to ptrace64.
+
 2013-08-29  Andrew Burgess  <aburgess@broadcom.com>
 
        * mi/mi-interp.c (mi_command_loop): Change signature to match

diff --git a/gdb/rs6000-nat.c b/gdb/rs6000-nat.c
index 804b31680b1b703d8a1ee5c6cd18cf09ce02480e..374976e25af851c5481eeb9ef068e3210d28871e 100644 (file)
--- a/gdb/rs6000-nat.c
+++ b/gdb/rs6000-nat.c
@@ -132,7 +132,7 @@ static int
 rs6000_ptrace32 (int req, int id, int *addr, int data, int *buf)
 {
 #ifdef HAVE_PTRACE64
-  int ret = ptrace64 (req, id, (long long) addr, data, buf);
+  int ret = ptrace64 (req, id, (uintptr_t) addr, data, buf);
 #else
   int ret = ptrace (req, id, (int *)addr, data, buf);
 #endif