radeonsi: Mixed colorbuffer formats are unsupported
authorAxel Davy <axel.davy@ens.fr>
Mon, 7 Mar 2016 21:26:22 +0000 (22:26 +0100)
committerAxel Davy <axel.davy@ens.fr>
Wed, 18 May 2016 21:37:14 +0000 (23:37 +0200)
Besides depth/stencil, the hardware doesn't support
mixed formats.

The GL state tracker doesn't make use of them.

Signed-off-by: Axel Davy <axel.davy@ens.fr>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/radeonsi/si_state.c

index 85d8509f1c842928e142b3a556b15f75f82f4233..aefa336c50fd6d49b044e6061a5bd590fafd8a17 100644 (file)
@@ -1145,6 +1145,11 @@ static uint32_t si_translate_colorformat(enum pipe_format format)
        if (desc->layout != UTIL_FORMAT_LAYOUT_PLAIN)
                return V_028C70_COLOR_INVALID;
 
+       /* hw cannot support mixed formats (except depth/stencil, since
+        * stencil is not written to). */
+       if (desc->is_mixed && desc->colorspace != UTIL_FORMAT_COLORSPACE_ZS)
+               return V_028C70_COLOR_INVALID;
+
        switch (desc->nr_channels) {
        case 1:
                switch (desc->channel[0].size) {
@@ -1423,6 +1428,11 @@ static uint32_t si_translate_texformat(struct pipe_screen *screen,
 
        /* R8G8Bx_SNORM - TODO CxV8U8 */
 
+       /* hw cannot support mixed formats (except depth/stencil, since only
+        * depth is read).*/
+       if (desc->is_mixed && desc->colorspace != UTIL_FORMAT_COLORSPACE_ZS)
+               goto out_unknown;
+
        /* See whether the components are of the same size. */
        for (i = 1; i < desc->nr_channels; i++) {
                uniform = uniform && desc->channel[0].size == desc->channel[i].size;