Implement "to_stopped_by_hw_breakpoint" for x86 debug registers.

Report that a thread is stopped by a hardware breakpoint if a non-data
watchpoint is set in DR6.  This change should be a no-op since a target
still needs to implement the "to_supports_stopped_by_hw_breakpoint"
method before this function is used.

gdb/ChangeLog:

	* nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
	* nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
	prototype.
	* x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
	(x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
	method.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 074bf08cd2c89ecc5b288b5148743c3c834acdfe..f5484617676d70cc37d9c1d0083921a44b239d75 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@
+2018-03-04  John Baldwin  <jhb@FreeBSD.org>
+
+       * nat/x86-dregs.c (x86_dr_stopped_by_hw_breakpoint): New function.
+       * nat/x86-dregs.h (x86_dr_stopped_by_hw_breakpoint): New
+       prototype.
+       * x86-nat.c (x86_stopped_by_hw_breakpoint): New function.
+       (x86_use_watchpoints): Set "stopped_by_hw_breakpoint" target
+       method.
+
 2018-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
 
        * common/gdb_vecs.c (free_char_ptr_vec): Remove.

diff --git a/gdb/nat/x86-dregs.c b/gdb/nat/x86-dregs.c
index c816473628faacacc6620693ec518fb0de017ded..f11a708e27aaeaf29740b70bbd62c25505c679b7 100644 (file)
--- a/gdb/nat/x86-dregs.c
+++ b/gdb/nat/x86-dregs.c
@@ -649,3 +649,48 @@ x86_dr_stopped_by_watchpoint (struct x86_debug_reg_state *state)
   CORE_ADDR addr = 0;
   return x86_dr_stopped_data_address (state, &addr);
 }
+
+/* Return non-zero if the inferior has some hardware breakpoint that
+   triggered.  Otherwise return zero.  */
+
+int
+x86_dr_stopped_by_hw_breakpoint (struct x86_debug_reg_state *state)
+{
+  CORE_ADDR addr = 0;
+  int i;
+  int rc = 0;
+  /* The current thread's DR_STATUS.  We always need to read this to
+     check whether some watchpoint caused the trap.  */
+  unsigned status;
+  /* We need DR_CONTROL as well, but only iff DR_STATUS indicates a
+     breakpoint trap.  Only fetch it when necessary, to avoid an
+     unnecessary extra syscall when no watchpoint triggered.  */
+  int control_p = 0;
+  unsigned control = 0;
+
+  /* As above, always read the current thread's debug registers rather
+     than trusting dr_mirror.  */
+  status = x86_dr_low_get_status ();
+
+  ALL_DEBUG_ADDRESS_REGISTERS (i)
+    {
+      if (!X86_DR_WATCH_HIT (status, i))
+       continue;
+
+      if (!control_p)
+       {
+         control = x86_dr_low_get_control ();
+         control_p = 1;
+       }
+
+      if (X86_DR_GET_RW_LEN (control, i) == 0)
+       {
+         addr = x86_dr_low_get_addr (i);
+         rc = 1;
+         if (show_debug_regs)
+           x86_show_dr (state, "watchpoint_hit", addr, -1, hw_execute);
+       }
+    }
+
+  return rc;
+}

diff --git a/gdb/nat/x86-dregs.h b/gdb/nat/x86-dregs.h
index dd6242eda9591972d08072f026f9d983d15f973c..e86e83aea0c91dc70773ad0794738213f5aa8982 100644 (file)
--- a/gdb/nat/x86-dregs.h
+++ b/gdb/nat/x86-dregs.h
@@ -128,4 +128,8 @@ extern int x86_dr_stopped_data_address (struct x86_debug_reg_state *state,
    Otherwise return false.  */
 extern int x86_dr_stopped_by_watchpoint (struct x86_debug_reg_state *state);
 
+/* Return true if the inferior has some hardware breakpoint that
+   triggered.  Otherwise return false.  */
+extern int x86_dr_stopped_by_hw_breakpoint (struct x86_debug_reg_state *state);
+
 #endif /* X86_DREGS_H */

diff --git a/gdb/x86-nat.c b/gdb/x86-nat.c
index b126c47c943411befc5cf0840b68a49833b13503..bec51373a66c92262a80833a707de91c8be2be28 100644 (file)
--- a/gdb/x86-nat.c
+++ b/gdb/x86-nat.c
@@ -260,6 +260,18 @@ x86_can_use_hw_breakpoint (struct target_ops *self,
   return 1;
 }
 
+/* Return non-zero if the inferior has some breakpoint that triggered.
+   Otherwise return zero.  */
+
+static int
+x86_stopped_by_hw_breakpoint (struct target_ops *ops)
+{
+  struct x86_debug_reg_state *state
+    = x86_debug_reg_state (ptid_get_pid (inferior_ptid));
+
+  return x86_dr_stopped_by_hw_breakpoint (state);
+}
+
 static void
 add_show_debug_regs_command (void)
 {
@@ -297,6 +309,11 @@ x86_use_watchpoints (struct target_ops *t)
   t->to_remove_watchpoint = x86_remove_watchpoint;
   t->to_insert_hw_breakpoint = x86_insert_hw_breakpoint;
   t->to_remove_hw_breakpoint = x86_remove_hw_breakpoint;
+
+  /* A target must provide an implementation of the
+     "to_supports_stopped_by_hw_breakpoint" target method before this
+     callback will be used.  */
+  t->to_stopped_by_hw_breakpoint = x86_stopped_by_hw_breakpoint;
 }
 
 void