draw: fix slot detection
authorZack Rusin <zackr@vmware.com>
Tue, 6 Aug 2013 06:54:36 +0000 (02:54 -0400)
committerZack Rusin <zackr@vmware.com>
Wed, 7 Aug 2013 00:23:57 +0000 (20:23 -0400)
Nowadays -1 for slots means that the semantic is not present, so
we need to store it in a signed variables, otherwise <0 comparisons
are pointless. Fixes
http://bugzilla.eng.vmware.com/show_bug.cgi?id=67811 (at least
with softpipe, edgeflags don't work wit llvmpipe)

Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
src/gallium/drivers/llvmpipe/lp_setup_context.h
src/gallium/drivers/llvmpipe/lp_setup_line.c

index ea1d0d688d8569ee729f332c320aee41fc1fb481..44be85fde1a57d4818d2ceccac9c09a013d8a9a1 100644 (file)
@@ -106,7 +106,7 @@ struct lp_setup_context
    float psize;
    unsigned viewport_index_slot;
    unsigned layer_slot;
-   unsigned face_slot;
+   int face_slot;
 
    struct pipe_framebuffer_state fb;
    struct u_rect framebuffer;
index 3b16163ba593a930796ed028dd5ef08346551515..a25a6b02f8d74f3731022a10127310f0000e1af3 100644 (file)
@@ -622,7 +622,6 @@ try_setup_line( struct lp_setup_context *setup,
    } else {
       line->inputs.frontfacing = TRUE;
    }
-   
 
    /* Setup parameter interpolants:
     */