projects
/
mesa.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e4c3e7f
)
mesa: Fix _mesa_lookup_parameter_constant's return value.
author
José Fonseca
<jfonseca@vmware.com>
Mon, 30 Aug 2010 12:48:21 +0000
(13:48 +0100)
committer
José Fonseca
<jfonseca@vmware.com>
Mon, 30 Aug 2010 12:48:21 +0000
(13:48 +0100)
Fixes gcc warning
In function ‘_mesa_add_unnamed_constant’:
warning: ‘pos’ may be used uninitialized in this function
but also what appears to be a bug.
src/mesa/program/prog_parameter.c
patch
|
blob
|
history
diff --git
a/src/mesa/program/prog_parameter.c
b/src/mesa/program/prog_parameter.c
index 40dc92cb201c7341dd686f0e9c7ab7e3a63b8577..6bf8a081b0299202c43281cef385d5f0f2b26548 100644
(file)
--- a/
src/mesa/program/prog_parameter.c
+++ b/
src/mesa/program/prog_parameter.c
@@
-482,8
+482,10
@@
_mesa_lookup_parameter_constant(const struct gl_program_parameter_list *list,
assert(vSize >= 1);
assert(vSize <= 4);
- if (!list)
- return -1;
+ if (!list) {
+ *posOut = -1;
+ return GL_FALSE;
+ }
for (i = 0; i < list->NumParameters; i++) {
if (list->Parameters[i].Type == PROGRAM_CONSTANT) {