Rename tdesc_register_size to tdesc_register_bitsize

tdesc_register_size returns number of bits, not bytes.
Rename to make it clearer.

Also, fixed bug in aarch64_get_tdesc_vq which assumed bytes.

gdb/
	* target-descriptions.c (tdesc_register_bitsize): Rename.
	* target-descriptions.h (tdesc_register_bitsize): Likewise.
	* rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
	* aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1de7230b07c773890f197101bce34ca82f3963c7..7c74c87d8c56ffd906d292550a6f45218d81a1a9 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2018-07-11  Alan Hayward  <alan.hayward@arm.com>
+
+       * target-descriptions.c (tdesc_register_bitsize): Rename.
+       * target-descriptions.h (tdesc_register_bitsize): Likewise.
+       * rs6000-tdep.c (rs6000_gdbarch_init): Use new name.
+       * aarch64-tdep.c (aarch64_get_tdesc_vq): Convert size.
+
 2018-07-10  Tom Tromey  <tom@tromey.com>
 
        * breakpoint.c (moribund_locations): Now static and a

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index 5120fffe776ada9fc5670ff4759c8e53378a8193..5c6eb985451c43909cc929b32eade09f778d0018 100644 (file)
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -2922,8 +2922,8 @@ aarch64_get_tdesc_vq (const struct target_desc *tdesc)
   if (feature_sve == nullptr)
     return 0;
 
-  uint64_t vl = tdesc_register_size (feature_sve,
-                                    aarch64_sve_register_names[0]);
+  uint64_t vl = tdesc_register_bitsize (feature_sve,
+                                       aarch64_sve_register_names[0]) / 8;
   return sve_vq_from_vl (vl);
 }
 

diff --git a/gdb/rs6000-tdep.c b/gdb/rs6000-tdep.c
index 4eeb62ac52fcfe0c0a3648e3e68b0bb23516c73f..45bf98267a99a1c8990f7b0b0f0788dd7b0e03d3 100644 (file)
--- a/gdb/rs6000-tdep.c
+++ b/gdb/rs6000-tdep.c
@@ -5953,7 +5953,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
       have_mq = tdesc_numbered_register (feature, tdesc_data, PPC_MQ_REGNUM,
                                         "mq");
 
-      tdesc_wordsize = tdesc_register_size (feature, "pc") / 8;
+      tdesc_wordsize = tdesc_register_bitsize (feature, "pc") / 8;
       if (wordsize == -1)
        wordsize = tdesc_wordsize;
 
@@ -5984,7 +5984,7 @@ rs6000_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
          /* The fpscr register was expanded in isa 2.05 to 64 bits
             along with the addition of the decimal floating point
             facility.  */
-         if (tdesc_register_size (feature, "fpscr") > 32)
+         if (tdesc_register_bitsize (feature, "fpscr") > 32)
            have_dfp = 1;
        }
       else

diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c
index 3d7aa2582e72815f98e77681fdec15acfb54ec43..a96416cd3cc94faf213cf576e9eac31524baa3ab 100644 (file)
--- a/gdb/target-descriptions.c
+++ b/gdb/target-descriptions.c
@@ -816,8 +816,7 @@ tdesc_numbered_register_choices (const struct tdesc_feature *feature,
    bits.  The register must exist.  */
 
 int
-tdesc_register_size (const struct tdesc_feature *feature,
-                    const char *name)
+tdesc_register_bitsize (const struct tdesc_feature *feature, const char *name)
 {
   struct tdesc_reg *reg = tdesc_find_register_early (feature, name);
 

diff --git a/gdb/target-descriptions.h b/gdb/target-descriptions.h
index 3ba71b1add638de35c3d5bc5b6f7943a32169369..87403acc0d4d3dc7da4f2ca12c4778d5b9a5d353 100644 (file)
--- a/gdb/target-descriptions.h
+++ b/gdb/target-descriptions.h
@@ -125,8 +125,8 @@ int tdesc_unnumbered_register (const struct tdesc_feature *feature,
 /* Search FEATURE for a register named NAME, and return its size in
    bits.  The register must exist.  */
 
-int tdesc_register_size (const struct tdesc_feature *feature,
-                        const char *name);
+int tdesc_register_bitsize (const struct tdesc_feature *feature,
+                           const char *name);
 
 /* Search FEATURE for a register with any of the names from NAMES
    (NULL-terminated).  Record REGNO and the register in DATA; when