dev-arm: PL031, fix AMBA ID and clock names
authorAdrian Herrera <adrian.herrera@arm.com>
Thu, 5 Dec 2019 16:21:01 +0000 (16:21 +0000)
committerGiacomo Travaglini <giacomo.travaglini@arm.com>
Fri, 28 Feb 2020 09:33:48 +0000 (09:33 +0000)
This patch fixes the AMBA ID of the PL031 RTC. It also adds the
"clock-names" property to its auto-DTB generation. This fixes and
enables correct probing from Linux.

Change-Id: I331bfa81664f57a35f21f35d658772eb40380e35
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/25432
Reviewed-by: Ciro Santilli <ciro.santilli@arm.com>
Maintainer: Giacomo Travaglini <giacomo.travaglini@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/dev/arm/RealView.py

index 25bad06ad7e169b0264a51823660df401d646bef..039df101d2f9deeb5ce57ec2f6a6769bb1db71b9 100644 (file)
@@ -484,7 +484,7 @@ class PL031(AmbaIntDevice):
     type = 'PL031'
     cxx_header = "dev/arm/rtc_pl031.hh"
     time = Param.Time('01/01/2009', "System time to use ('Now' for actual time)")
-    amba_id = 0x00341031
+    amba_id = 0x00041031
 
     def generateDeviceTree(self, state):
         node = self.generateBasicPioDeviceNode(state, 'rtc', self.pio_addr,
@@ -493,6 +493,7 @@ class PL031(AmbaIntDevice):
         node.appendCompatible(["arm,pl031", "arm,primecell"])
         clock = state.phandle(self.clk_domain.unproxy(self))
         node.append(FdtPropertyWords("clocks", clock))
+        node.append(FdtPropertyStrings("clock-names", ["apb_pclk"]))
 
         yield node