re PR libgcj/8481 (java.Random.nextInt(int) may return negative)

	From svens@it.uu.se.  For PR libgcj/8481.
	* java/util/Random.java (nextInt(int)): Only use 31 bits.

From-SVN: r58876

diff --git a/libjava/ChangeLog b/libjava/ChangeLog
index 6a6adf974bfb521b07ffcb317cd4921fca3bbcc7..9dad8792e09b10ca1694b3316ac172f93fa532af 100644 (file)
--- a/libjava/ChangeLog
+++ b/libjava/ChangeLog
@@ -1,3 +1,8 @@
+2002-11-06  Tom Tromey  <tromey@redhat.com>
+
+       From svens@it.uu.se.  For PR libgcj/8481.
+       * java/util/Random.java (nextInt(int)): Only use 31 bits.
+
 2002-11-06  Tom Tromey  <tromey@redhat.com>
 
        * jni.cc (array_from_valist): Assume that jlong won't be

diff --git a/libjava/java/util/Random.java b/libjava/java/util/Random.java
index 500a02d3765ed0b61aa39fe6727dba74ee9d1319..6e7d8cf249167818c7d90aeda1a380ff15ba5abb 100644 (file)
--- a/libjava/java/util/Random.java
+++ b/libjava/java/util/Random.java
@@ -259,7 +259,7 @@ public int nextInt(int n)
   int bits, val;
   do
   {
-    bits = next(32);
+    bits = next(31);
     val = bits % n;
   }
   while(bits - val + (n-1) < 0);
@@ -296,7 +296,7 @@ public int nextInt(int n)
     int bits, val;
     do
       {
-        bits = next(32);
+        bits = next(31);
         val = bits % n;
       }
     while (bits - val + (n - 1) < 0);