re PR tree-optimization/48837 (Wrong optimization of recursive function calls)

	PR tree-optimization/48837
	* tree-tailcall.c (tree_optimize_tail_calls_1): Do not mark tailcalls
	when accumulator transformation is performed.

	* gcc.dg/pr48837.c: New testcase.

From-SVN: r173534

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 6534bbc46eb6ba0b97dc92caaa7e1bb9dfcd6281..a3f6a11146388635e40fde8cfab08124ebd2b90e 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2011-05-07  Zdenek Dvorak  <ook@ucw.cz>
+
+       PR tree-optimization/48837
+       * tree-tailcall.c (tree_optimize_tail_calls_1): Do not mark tailcalls
+       when accumulator transformation is performed.
+
 2011-05-06  Jan Hubicka  <jh@suse.cz>
 
        * i386.h (ix86_tune_indices): Add X86_TUNE_SOFTWARE_PREFETCHING_BENEFICIAL.

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index ea142c2e956b0cf25448e25cd045970d0b623ed7..735ac689dd3dcd4858ec8e31f311687d769c60dd 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2011-05-07  Zdenek Dvorak  <ook@ucw.cz>
+
+       PR tree-optimization/48837
+       * gcc.dg/pr48837.c: New testcase.
+
 2011-05-06  Jason Merrill  <jason@redhat.com>
 
        * g++.dg/cpp0x/constexpr-condition2.C: New.

diff --git a/gcc/testsuite/gcc.dg/pr48837.c b/gcc/testsuite/gcc.dg/pr48837.c
new file mode 100644 (file)
index 0000000..ffc65b9
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr48837.c
@@ -0,0 +1,30 @@
+/* PR tree-optimization/48837 */
+/* { dg-do run } */
+/* { dg-options "-O2" } */
+
+void abort (void);
+
+__attribute__((noinline))
+int baz(void)
+{
+  return 1;
+}
+
+inline const int *bar(const int *a, const int *b)
+{
+ return *a ? a : b;
+}
+
+int foo(int a, int b)
+{
+   return a || b ? baz() : foo(*bar(&a, &b), 1) + foo(1, 0);
+}
+
+int main(void)
+{
+ if (foo(0, 0) != 2)
+   abort();
+
+ return 0;
+}
+

diff --git a/gcc/tree-tailcall.c b/gcc/tree-tailcall.c
index c94d6ca824bcd5e171bd723b030983b2c12e15ad..6a2308028bb29f6a9b5927758e6c6c9f43fafe82 100644 (file)
--- a/gcc/tree-tailcall.c
+++ b/gcc/tree-tailcall.c
@@ -1021,6 +1021,14 @@ tree_optimize_tail_calls_1 (bool opt_tailcalls)
                                             integer_one_node);
     }
 
+  if (a_acc || m_acc)
+    {
+      /* When the tail call elimination using accumulators is performed,
+        statements adding the accumulated value are inserted at all exits.
+        This turns all other tail calls to non-tail ones.  */
+      opt_tailcalls = false;
+    }
+
   for (; tailcalls; tailcalls = next)
     {
       next = tailcalls->next;