radeonsi: fix some reported undefined left-shifts
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Sat, 30 Apr 2016 03:29:22 +0000 (22:29 -0500)
committerNicolai Hähnle <nicolai.haehnle@amd.com>
Sat, 7 May 2016 21:46:59 +0000 (16:46 -0500)
One of these is an unsigned bitfield, which I suspect is a false positive, but
gcc 5.3.1 complains about it with -fsanitize=undefined.

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
src/gallium/drivers/radeonsi/si_state.c

index c6e10b76f70df65a84ef4ffa0352ace1b0b6aa2f..c4af77e149c8147edeb5a70403335deac82c7ede 100644 (file)
@@ -464,7 +464,7 @@ static void *si_create_blend_state_mode(struct pipe_context *ctx,
                        continue;
 
                /* cb_render_state will disable unused ones */
-               blend->cb_target_mask |= state->rt[j].colormask << (4 * i);
+               blend->cb_target_mask |= (unsigned)state->rt[j].colormask << (4 * i);
 
                if (!state->rt[j].blend_enable) {
                        si_pm4_set_reg(pm4, R_028780_CB_BLEND0_CONTROL + i * 4, blend_cntl);
@@ -528,7 +528,7 @@ static void *si_create_blend_state_mode(struct pipe_context *ctx,
                }
                si_pm4_set_reg(pm4, R_028780_CB_BLEND0_CONTROL + i * 4, blend_cntl);
 
-               blend->blend_enable_4bit |= 0xf << (i * 4);
+               blend->blend_enable_4bit |= 0xfu << (i * 4);
 
                /* This is only important for formats without alpha. */
                if (srcRGB == PIPE_BLENDFACTOR_SRC_ALPHA ||
@@ -537,7 +537,7 @@ static void *si_create_blend_state_mode(struct pipe_context *ctx,
                    dstRGB == PIPE_BLENDFACTOR_SRC_ALPHA_SATURATE ||
                    srcRGB == PIPE_BLENDFACTOR_INV_SRC_ALPHA ||
                    dstRGB == PIPE_BLENDFACTOR_INV_SRC_ALPHA)
-                       blend->need_src_alpha_4bit |= 0xf << (i * 4);
+                       blend->need_src_alpha_4bit |= 0xfu << (i * 4);
        }
 
        if (blend->cb_target_mask) {