PR24689 again, string table corruption

Depending on optimisation level and gcc version, git commit 890f750a3b
introduces a false positive warning that i_shdrp may be used
uninitialized.

	PR 24689
	* elfcode.h (elf_object_p): Warning fix.

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index bc7671e9ea300ca74ab077f572c963f98fdad831..964ab71b204cdfd6a1931248889600f8601b361f 100644 (file)
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2019-06-23  Alan Modra  <amodra@gmail.com>
+
+       PR 24689
+       * elfcode.h (elf_object_p): Warning fix.
+
 2019-06-21  Alan Modra  <amodra@gmail.com>
 
        PR 24689

diff --git a/bfd/elfcode.h b/bfd/elfcode.h
index 5180f79a74dfea8aab803e6c9d70429c146bedab..9a73c3b71f52daa83b17350489c9275aca2bc3d2 100644 (file)
--- a/bfd/elfcode.h
+++ b/bfd/elfcode.h
@@ -749,11 +749,7 @@ elf_object_p (bfd *abfd)
                  != 0))
            abfd->flags &= ~D_PAGED;
        }
-    }
 
-  /* A further sanity check.  */
-  if (i_ehdrp->e_shnum != 0)
-    {
       if (i_ehdrp->e_shstrndx >= elf_numsections (abfd)
          || i_shdrp[i_ehdrp->e_shstrndx].sh_type != SHT_STRTAB)
        {