convert to_enable_tracepoint

2014-02-19  Tom Tromey  <tromey@redhat.com>

	* target-delegates.c: Rebuild.
	* target.c (update_current_target): Don't inherit or default
	to_enable_tracepoint.
	* target.h (struct target_ops) <to_enable_tracepoint>: Use
	TARGET_DEFAULT_NORETURN.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5823590d5e44160fd84d3d8a23659d0befb621cf..fb67ce371d3a76ae817f337ae77da3a517f0fca2 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2014-02-19  Tom Tromey  <tromey@redhat.com>
+
+       * target-delegates.c: Rebuild.
+       * target.c (update_current_target): Don't inherit or default
+       to_enable_tracepoint.
+       * target.h (struct target_ops) <to_enable_tracepoint>: Use
+       TARGET_DEFAULT_NORETURN.
+
 2014-02-19  Tom Tromey  <tromey@redhat.com>
 
        * target-delegates.c: Rebuild.

diff --git a/gdb/target-delegates.c b/gdb/target-delegates.c
index c158538b3213dac51fdac815f3721d7536940e79..3e9ea0fcbdc3eb87304bec8ac3b498c979ec8bda 100644 (file)
--- a/gdb/target-delegates.c
+++ b/gdb/target-delegates.c
@@ -689,6 +689,19 @@ tdefault_download_trace_state_variable (struct target_ops *self, struct trace_st
   tcomplain ();
 }
 
+static void
+delegate_enable_tracepoint (struct target_ops *self, struct bp_location *arg1)
+{
+  self = self->beneath;
+  self->to_enable_tracepoint (self, arg1);
+}
+
+static void
+tdefault_enable_tracepoint (struct target_ops *self, struct bp_location *arg1)
+{
+  tcomplain ();
+}
+
 static int
 delegate_supports_btrace (struct target_ops *self)
 {
@@ -825,6 +838,8 @@ install_delegators (struct target_ops *ops)
     ops->to_can_download_tracepoint = delegate_can_download_tracepoint;
   if (ops->to_download_trace_state_variable == NULL)
     ops->to_download_trace_state_variable = delegate_download_trace_state_variable;
+  if (ops->to_enable_tracepoint == NULL)
+    ops->to_enable_tracepoint = delegate_enable_tracepoint;
   if (ops->to_supports_btrace == NULL)
     ops->to_supports_btrace = delegate_supports_btrace;
 }
@@ -892,5 +907,6 @@ install_dummy_methods (struct target_ops *ops)
   ops->to_download_tracepoint = tdefault_download_tracepoint;
   ops->to_can_download_tracepoint = tdefault_can_download_tracepoint;
   ops->to_download_trace_state_variable = tdefault_download_trace_state_variable;
+  ops->to_enable_tracepoint = tdefault_enable_tracepoint;
   ops->to_supports_btrace = tdefault_supports_btrace;
 }

diff --git a/gdb/target.c b/gdb/target.c
index 358cc56f5eeb52badaee8c1e07b62ccf0f6f405c..0e3a223ca7fe2eb45907a0d8f6dcb7929f694933 100644 (file)
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -692,7 +692,7 @@ update_current_target (void)
       /* Do not inherit to_download_tracepoint.  */
       /* Do not inherit to_can_download_tracepoint.  */
       /* Do not inherit to_download_trace_state_variable.  */
-      INHERIT (to_enable_tracepoint, t);
+      /* Do not inherit to_enable_tracepoint.  */
       INHERIT (to_disable_tracepoint, t);
       INHERIT (to_trace_set_readonly_regions, t);
       INHERIT (to_trace_start, t);
@@ -752,9 +752,6 @@ update_current_target (void)
            (void (*) (struct target_ops *, ptid_t))
            target_ignore);
   current_target.to_read_description = NULL;
-  de_fault (to_enable_tracepoint,
-           (void (*) (struct target_ops *, struct bp_location *))
-           tcomplain);
   de_fault (to_disable_tracepoint,
            (void (*) (struct target_ops *, struct bp_location *))
            tcomplain);

diff --git a/gdb/target.h b/gdb/target.h
index 584d3c5ba7874ce67003a8e9634f56bb63274db3..d38fd2cf84db58cf71f01db185bcb0b9cd759273 100644 (file)
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -821,7 +821,8 @@ struct target_ops
 
     /* Enable a tracepoint on the target.  */
     void (*to_enable_tracepoint) (struct target_ops *,
-                                 struct bp_location *location);
+                                 struct bp_location *location)
+      TARGET_DEFAULT_NORETURN (tcomplain ());
 
     /* Disable a tracepoint on the target.  */
     void (*to_disable_tracepoint) (struct target_ops *,