[Ada] Copy index expression trees rather than relocating them

2018-05-28  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

	* exp_aggr.adb (Flatten): Copy tree of expression in a component
	association with a range or a set of discrete choices, rather than
	relocating the node. This avoids inconsistencies in the tree when
	handling nested subprograms with uplevel references for LLVM.

From-SVN: r260829

diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index a9f89f5749cbaf723440ed70a30fa2660f3b7354..95e4822412f7cf7d440c8d1e53bc39b37d05cd1a 100644 (file)
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,3 +1,10 @@
+2018-05-28  Ed Schonberg  <schonberg@adacore.com>
+
+       * exp_aggr.adb (Flatten): Copy tree of expression in a component
+       association with a range or a set of discrete choices, rather than
+       relocating the node. This avoids inconsistencies in the tree when
+       handling nested subprograms with uplevel references for LLVM.
+
 2018-05-28  Arnaud Charlet  <charlet@adacore.com>
 
        * exp_util.adb (Possible_Bit_Aligned_Component): Always return False in

diff --git a/gcc/ada/exp_aggr.adb b/gcc/ada/exp_aggr.adb
index c7158a395545488702f591e9e39d6f476bd97a31..cedc7224f28970b86393a2daabd3d6129de839b3 100644 (file)
--- a/gcc/ada/exp_aggr.adb
+++ b/gcc/ada/exp_aggr.adb
@@ -4490,7 +4490,9 @@ package body Exp_Aggr is
                      return False;
                   end if;
 
-                  Vals (Num) := Relocate_Node (Elmt);
+                  --  Duplicate expression for each index it covers.
+
+                  Vals (Num) := New_Copy_Tree (Elmt);
                   Num := Num + 1;
 
                   Next (Elmt);