re PR target/88457 (ICE: Max. number of generated reload insns per insn is achieved...

2018-12-20  Vladimir Makarov  <vmakarov@redhat.com>

	PR target/88457
	* ira-color.c (fast_allocation): Choose the best cost hard reg.

2018-12-20  Vladimir Makarov  <vmakarov@redhat.com>

	PR target/88457
	* ira-color.c (fast_allocation): Choose the best cost hard reg.

From-SVN: r267307

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 5fa350f850b7f8b7bdb45e92b91ea82fa47127df..4be16c15f86185d838fad2cbcd489f8613324fcd 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-20  Vladimir Makarov  <vmakarov@redhat.com>
+
+       PR target/88457
+       * ira-color.c (fast_allocation): Choose the best cost hard reg.
+
 2018-12-20  Richard Sandiford  <richard.sandiford@arm.com>
 
        * config/aarch64/iterators.md (SVE_INT_UNARY, fp_int_op): Add abs.

diff --git a/gcc/ira-color.c b/gcc/ira-color.c
index 7087fb99959d4c7944b2c6cbd93ddfda8294102b..02002f783d42ddad2827c833c8a220eb51cd426b 100644 (file)
--- a/gcc/ira-color.c
+++ b/gcc/ira-color.c
@@ -4852,7 +4852,8 @@ color (void)
 static void
 fast_allocation (void)
 {
-  int i, j, k, num, class_size, hard_regno;
+  int i, j, k, num, class_size, hard_regno, best_hard_regno, cost, min_cost;
+  int *costs;
 #ifdef STACK_REGS
   bool no_stack_reg_p;
 #endif
@@ -4903,6 +4904,9 @@ fast_allocation (void)
       no_stack_reg_p = ALLOCNO_NO_STACK_REG_P (a);
 #endif
       class_size = ira_class_hard_regs_num[aclass];
+      costs = ALLOCNO_HARD_REG_COSTS (a);
+      min_cost = INT_MAX;
+      best_hard_regno = -1;
       for (j = 0; j < class_size; j++)
        {
          hard_regno = ira_class_hard_regs[aclass][j];
@@ -4915,16 +4919,28 @@ fast_allocation (void)
              || (TEST_HARD_REG_BIT
                  (ira_prohibited_class_mode_regs[aclass][mode], hard_regno)))
            continue;
-         ALLOCNO_HARD_REGNO (a) = hard_regno;
-         for (l = 0; l < nr; l++)
+         if (costs == NULL)
+           {
+             best_hard_regno = hard_regno;
+             break;
+           }
+         cost = costs[j];
+         if (min_cost > cost)
            {
-             ira_object_t obj = ALLOCNO_OBJECT (a, l);
-             for (r = OBJECT_LIVE_RANGES (obj); r != NULL; r = r->next)
-               for (k = r->start; k <= r->finish; k++)
-                 IOR_HARD_REG_SET (used_hard_regs[k],
-                                   ira_reg_mode_hard_regset[hard_regno][mode]);
+             min_cost = cost;
+             best_hard_regno = hard_regno;
            }
-         break;
+       }
+      if (best_hard_regno < 0)
+       continue;
+      ALLOCNO_HARD_REGNO (a) = hard_regno = best_hard_regno;
+      for (l = 0; l < nr; l++)
+       {
+         ira_object_t obj = ALLOCNO_OBJECT (a, l);
+         for (r = OBJECT_LIVE_RANGES (obj); r != NULL; r = r->next)
+           for (k = r->start; k <= r->finish; k++)
+             IOR_HARD_REG_SET (used_hard_regs[k],
+                               ira_reg_mode_hard_regset[hard_regno][mode]);
        }
     }
   ira_free (sorted_allocnos);

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index bfc24420ed3e822d79694069808d578c3b476017..33a4776b9212c078fef4d49a0997f7a824afb5eb 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2018-12-20  Vladimir Makarov  <vmakarov@redhat.com>
+
+       PR target/88457
+       * gcc.target/powerpc/pr88457.c: New.
+
 2018-12-20  Jakub Jelinek  <jakub@redhat.com>
 
        PR c++/88180

diff --git a/gcc/testsuite/gcc.target/powerpc/pr88457.c b/gcc/testsuite/gcc.target/powerpc/pr88457.c
new file mode 100644 (file)
index 0000000..8ab2da5
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/pr88457.c
@@ -0,0 +1,13 @@
+/* { dg-do compile  { target { powerpc64*-*-* } } } */
+/* { dg-options "-m32 -mcpu=power7 -O1 -fexpensive-optimizations --param ira-max-conflict-table-size=0 --param max-cse-insns=3 -c -mcpu=e300c3" } */
+
+__attribute__((target_clones("cpu=power9,default")))
+long mod_func (long a, long b)
+{
+  return a % b;
+}
+
+long mod_func_or (long a, long b, long c)
+{
+  return mod_func (a, b) | c;
+}