prog_to_nir: Make RSQ properly take the absolute value of its argument.
authorKenneth Graunke <kenneth@whitecape.org>
Thu, 4 Jun 2015 08:24:07 +0000 (01:24 -0700)
committerKenneth Graunke <kenneth@whitecape.org>
Thu, 4 Jun 2015 22:32:46 +0000 (15:32 -0700)
I just botched this when writing the original code.

From the ARB_vertex_program specification:
"The RSQ instruction approximates the reciprocal of the square root of
 the absolute value of the scalar operand and replicates it to all four
 components of the result vector."

Fixes a Glean vertProg1 subtest:
RSQ test 2 (reciprocal square root of negative value)

Cc: mesa-stable@lists.freedesktop.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=90547
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
src/mesa/program/prog_to_nir.c

index e986e5115143972860f7747882743329f236b0bd..d3e3f15c959510caf96bd64a93eef4d28d432a1f 100644 (file)
@@ -764,7 +764,8 @@ ptn_emit_instruction(struct ptn_compile *c, struct prog_instruction *prog_inst)
 
    switch (op) {
    case OPCODE_RSQ:
-      ptn_move_dest(b, dest, nir_frsq(b, ptn_channel(b, src[0], X)));
+      ptn_move_dest(b, dest,
+                    nir_frsq(b, nir_fabs(b, ptn_channel(b, src[0], X))));
       break;
 
    case OPCODE_RCP: