re PR sanitizer/64906 (-fsanitize=integer-divide-by-zero creates false -Wmaybe-uninit...

	PR sanitizer/64906
	* c-ubsan.c (ubsan_instrument_division): Also pre-evaluate OP1.

	* c-c++-common/ubsan/pr64906.c: New test.

From-SVN: r228112

diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog
index e409150ba613c2bd14bdfd46ae2900ca4d75bdaf..b9feff6e55cffc2cd00a73d2b42dff3404e298e3 100644 (file)
--- a/gcc/c-family/ChangeLog
+++ b/gcc/c-family/ChangeLog
@@ -1,3 +1,8 @@
+2015-09-25  Marek Polacek  <polacek@redhat.com>
+
+       PR sanitizer/64906
+       * c-ubsan.c (ubsan_instrument_division): Also pre-evaluate OP1.
+
 2015-09-24  Patrick Palka  <ppalka@gcc.gnu.org>
 
        * c-indentation.c (should_warn_for_misleading_indentation):

diff --git a/gcc/c-family/c-ubsan.c b/gcc/c-family/c-ubsan.c
index e0cce8467e4c235ccf54878836543cc4ea92fab0..d2bc264f632ffeba0fab9615b50f7b30d6e76f67 100644 (file)
--- a/gcc/c-family/c-ubsan.c
+++ b/gcc/c-family/c-ubsan.c
@@ -104,6 +104,7 @@ ubsan_instrument_division (location_t loc, tree op0, tree op1)
        }
     }
   t = fold_build2 (COMPOUND_EXPR, TREE_TYPE (t), unshare_expr (op0), t);
+  t = fold_build2 (COMPOUND_EXPR, TREE_TYPE (t), unshare_expr (op1), t);
   if (flag_sanitize_undefined_trap_on_error)
     tt = build_call_expr_loc (loc, builtin_decl_explicit (BUILT_IN_TRAP), 0);
   else

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 193eb8e99b4d9ddb508b9ed00e6d69f9b2e080f9..cfa23c659b85bc4594c666c44aac2a2280187f04 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-09-25  Marek Polacek  <polacek@redhat.com>
+
+       PR sanitizer/64906
+       * c-c++-common/ubsan/pr64906.c: New test.
+
 2015-09-24  H.J. Lu  <hongjiu.lu@intel.com>
 
        * gcc.target/i386/pr66749.c (dg-options): Replace -mtune=iamcu

diff --git a/gcc/testsuite/c-c++-common/ubsan/pr64906.c b/gcc/testsuite/c-c++-common/ubsan/pr64906.c
new file mode 100644 (file)
index 0000000..e0ac0ee
--- /dev/null
+++ b/gcc/testsuite/c-c++-common/ubsan/pr64906.c
@@ -0,0 +1,12 @@
+/* PR sanitizer/64906 */
+/* { dg-do compile } */
+/* { dg-options "-fsanitize=integer-divide-by-zero -O -Werror=maybe-uninitialized" } */
+
+int
+fn1 (int f, int s)
+{
+  int ret = 0;
+  if (f)
+    ret = s / (f ? (unsigned long) 8 : 0);
+  return ret;
+}