re PR bootstrap/63888 (bootstrap failed when configured with -with-build-config=boots...
authorMax Ostapenko <m.ostapenko@partner.samsung.com>
Wed, 21 Oct 2015 07:47:54 +0000 (10:47 +0300)
committerMaxim Ostapenko <chefmax@gcc.gnu.org>
Wed, 21 Oct 2015 07:47:54 +0000 (10:47 +0300)
libsanitizer/

PR bootstrap/63888
Reapply:
2015-02-20  Jakub Jelinek  <jakub@redhat.com>

* asan/asan_globals.cc (RegisterGlobal): Disable detect_odr_violation
support until it is rewritten upstream.

* c-c++-common/asan/pr63888.c: New test.

From-SVN: r229114

libsanitizer/ChangeLog
libsanitizer/asan/asan_globals.cc

index 4e463efec4665bcf578f334d3b5d16ddeffe89e5..80ce1585857aacec7110c77415d511c263116d2a 100644 (file)
@@ -1,3 +1,14 @@
+2015-10-21  Maxim Ostapenko  <m.ostapenko@partner.samsung.com>
+
+       PR bootstrap/63888
+       Reapply:
+       2015-02-20  Jakub Jelinek  <jakub@redhat.com>
+
+       * asan/asan_globals.cc (RegisterGlobal): Disable detect_odr_violation
+       support until it is rewritten upstream.
+
+       * c-c++-common/asan/pr63888.c: New test.
+
 2015-10-21  Maxim Ostapenko  <m.ostapenko@partner.samsung.com>
 
        PR sanitizer/63958
index b132c8b09b9116fa4cc163e0864a14c344410984..9c3588b8e081f5101dfb0c67ab231338f985437c 100644 (file)
@@ -144,7 +144,9 @@ static void RegisterGlobal(const Global *g) {
   CHECK(AddrIsInMem(g->beg));
   CHECK(AddrIsAlignedByGranularity(g->beg));
   CHECK(AddrIsAlignedByGranularity(g->size_with_redzone));
-  if (flags()->detect_odr_violation) {
+  // This "ODR violation" detection is fundamentally incompatible with
+  // how GCC registers globals.  Disable as useless until rewritten upstream.
+  if (0 && flags()->detect_odr_violation) {
     // Try detecting ODR (One Definition Rule) violation, i.e. the situation
     // where two globals with the same name are defined in different modules.
     if (__asan_region_is_poisoned(g->beg, g->size_with_redzone)) {