re PR target/63965 (ICE: in extract_constrain_insn, at recog.c:2230 on ppc64)

2014-11-24  Michael Meissner  <meissner@linux.vnet.ibm.com>

	PR target/63965
	* config/rs6000/rs6000.c (rs6000_setup_reg_addr_masks): Do not set
	Altivec & -16 mask if the type is not valid for Altivec registers.
	(rs6000_secondary_reload_memory): Add support for ((reg + const) +
	reg) that occurs during push_reload processing.

	* config/rs6000/altivec.md (altivec_mov<mode>): Add instruction
	alternative for moving constant vectors which are easy altivec
	constants to GPRs.  Set the length attribute each of the
	alternatives.

From-SVN: r218028

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 5df9ef66bd454f2c253492ecb3440afc7635e02c..5db7497608b12f80a6059bb202cd54f0df3ff949 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,6 +1,16 @@
 2014-11-24  Michael Meissner  <meissner@linux.vnet.ibm.com>
 
        PR target/63965
+       * config/rs6000/rs6000.c (rs6000_setup_reg_addr_masks): Do not set
+       Altivec & -16 mask if the type is not valid for Altivec registers.
+       (rs6000_secondary_reload_memory): Add support for ((reg + const) +
+       reg) that occurs during push_reload processing.
+
+       * config/rs6000/altivec.md (altivec_mov<mode>): Add instruction
+       alternative for moving constant vectors which are easy altivec
+       constants to GPRs.  Set the length attribute each of the
+       alternatives.
+
        * config/rs6000/rs6000-cpus.def: Undo November 21st changes, a
        work in progress patch was committed instead of the fixes for
        63965.

diff --git a/gcc/config/rs6000/altivec.md b/gcc/config/rs6000/altivec.md
index d46ef191409211a0a9d213b57fb4e657cd5a3cb4..3f52ca0c585e8b4b8de89c643a74f97d3182022a 100644 (file)
--- a/gcc/config/rs6000/altivec.md
+++ b/gcc/config/rs6000/altivec.md
@@ -189,8 +189,8 @@
 
 ;; Vector move instructions.
 (define_insn "*altivec_mov<mode>"
-  [(set (match_operand:VM2 0 "nonimmediate_operand" "=Z,v,v,*Y,*r,*r,v,v")
-       (match_operand:VM2 1 "input_operand" "v,Z,v,r,Y,r,j,W"))]
+  [(set (match_operand:VM2 0 "nonimmediate_operand" "=Z,v,v,*Y,*r,*r,v,v,*r")
+       (match_operand:VM2 1 "input_operand" "v,Z,v,r,Y,r,j,W,W"))]
   "VECTOR_MEM_ALTIVEC_P (<MODE>mode)
    && (register_operand (operands[0], <MODE>mode) 
        || register_operand (operands[1], <MODE>mode))"
@@ -205,10 +205,12 @@
     case 5: return "#";
     case 6: return "vxor %0,%0,%0";
     case 7: return output_vec_const_move (operands);
+    case 8: return "#";
     default: gcc_unreachable ();
     }
 }
-  [(set_attr "type" "vecstore,vecload,vecsimple,store,load,*,vecsimple,*")])
+  [(set_attr "type" "vecstore,vecload,vecsimple,store,load,*,vecsimple,*,*")
+   (set_attr "length" "4,4,4,20,20,20,4,8,32")])
 
 ;; Unlike other altivec moves, allow the GPRs, since a normal use of TImode
 ;; is for unions.  However for plain data movement, slightly favor the vector

diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index ea3e51120140c31c23e67d407e0dd1d59558c960..a87e762e56de583d703134e8cfc4404d6ae70d70 100644 (file)
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -2505,7 +2505,8 @@ rs6000_setup_reg_addr_masks (void)
 
          /* VMX registers can do (REG & -16) and ((REG+REG) & -16)
             addressing on 128-bit types.  */
-         if (rc == RELOAD_REG_VMX && GET_MODE_SIZE (m2) == 16)
+         if (rc == RELOAD_REG_VMX && GET_MODE_SIZE (m2) == 16
+             && (addr_mask & RELOAD_REG_VALID) != 0)
            addr_mask |= RELOAD_REG_AND_M16;
 
          reg_addr[m].addr_mask[rc] = addr_mask;
@@ -16652,6 +16653,17 @@ rs6000_secondary_reload_memory (rtx addr,
            }
        }
 
+      /* (plus (plus (reg) (constant)) (reg)) is also generated during
+        push_reload processing, so handle it now.  */
+      else if (GET_CODE (plus_arg0) == PLUS && REG_P (plus_arg1))
+       {
+         if ((addr_mask & RELOAD_REG_INDEXED) == 0)
+           {
+             extra_cost = 1;
+             type = "indexed #2";
+           }
+       }
+
       else if (!base_reg_operand (plus_arg0, GET_MODE (plus_arg0)))
        {
          fail_msg = "no base register #2";