PPC/GAS: Correct a signed vs unsigned comparison error with GCC 4.1

Fix a build error:

cc1: warnings being treated as errors
.../gas/config/tc-ppc.c: In function 'ppc_dwsect':
.../gas/config/tc-ppc.c:4091: warning: comparison between signed and unsigned
make[4]: *** [config/tc-ppc.o] Error 1

observed with GCC 4.1.2 with the `powerpc-beos' target.

Here `flag' identifies the type of a DWARF section, as used with the the
first operand to the `.dwsect' pseudo-op, and has no notion of a sign,
or for that matter being arithmetic in the first place[1].  We already
handle this correctly with the `flag' member of the `xcoff_dwsect_name'
structure, however not in the local variable used in GAS to hold the
parsed value of said `.dwsect' pseudo-op's operand.

Use an unsigned data type in GAS then too, observing that both `offsetT'
and `valueT' have the same width, as they correspond to `bfd_signed_vma'
and `bfd_vma' respectively.

References:

[1] "AIX Version 7.2: Assembler Language Reference", IBM Corporation
    2015, 2018, Section ".dwsect pseudo-op", pp. 531-532

	gas/
	* config/tc-ppc.c (ppc_dwsect): Use `valueT' rather than
	`offsetT' as the type of `flag'.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 47e1f7a328ecc37099562bc453089b90cda2d9b0..91af84b826dec0f90c1c9d2f796c7b8584dde055 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2018-09-20  Maciej W. Rozycki  <macro@linux-mips.org>
+
+       * config/tc-ppc.c (ppc_dwsect): Use `valueT' rather than
+       `offsetT' as the type of `flag'.
+
 2018-09-20  Maciej W. Rozycki  <macro@linux-mips.org>
 
        * config/tc-arc.c (md_number_to_chars_midend): Append `ull' to

diff --git a/gas/config/tc-ppc.c b/gas/config/tc-ppc.c
index a44b30068f2a9a756f3871b53dcb36285a32e454..d587a50ca7b5a95afb06cf47188ad3db834aefba 100644 (file)
--- a/gas/config/tc-ppc.c
+++ b/gas/config/tc-ppc.c
@@ -4077,7 +4077,7 @@ ppc_change_debug_section (unsigned int idx, subsegT subseg)
 static void
 ppc_dwsect (int ignore ATTRIBUTE_UNUSED)
 {
-  offsetT flag;
+  valueT flag;
   symbolS *opt_label;
   const struct xcoff_dwsect_name *dw;
   struct dw_subsection *subseg;