re PR c/63495 (struct __attribute__ ((aligned (8))) broken on x86)

	PR c/63495
	* stor-layout.c (min_align_of_type): Don't decrease alignment
	through BIGGEST_FIELD_ALIGNMENT or ADJUST_FIELD_ALIGN if
	TYPE_USER_ALIGN is set.

	* gcc.target/i386/pr63495.c: New test.

From-SVN: r216101

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index d418235e08f5c946434edd53e648989fbb6ba2ae..55c99d40357341d711408a1b0ab8c09f78bfc7f1 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2014-10-10  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c/63495
+       * stor-layout.c (min_align_of_type): Don't decrease alignment
+       through BIGGEST_FIELD_ALIGNMENT or ADJUST_FIELD_ALIGN if
+       TYPE_USER_ALIGN is set.
+
 2014-10-10  Uros Bizjak  <ubizjak@gmail.com>
 
        PR rtl-optimization/63483

diff --git a/gcc/stor-layout.c b/gcc/stor-layout.c
index 8328326facff143a128ad1e69dd95cfffad0a073..eefc52a5893fa3c7f154767ee37e17538281ee0c 100644 (file)
--- a/gcc/stor-layout.c
+++ b/gcc/stor-layout.c
@@ -2400,17 +2400,19 @@ min_align_of_type (tree type)
 {
   unsigned int align = TYPE_ALIGN (type);
   align = MIN (align, BIGGEST_ALIGNMENT);
+  if (!TYPE_USER_ALIGN (type))
+    {
 #ifdef BIGGEST_FIELD_ALIGNMENT
-  align = MIN (align, BIGGEST_FIELD_ALIGNMENT);
+      align = MIN (align, BIGGEST_FIELD_ALIGNMENT);
 #endif
-  unsigned int field_align = align;
+      unsigned int field_align = align;
 #ifdef ADJUST_FIELD_ALIGN
-  tree field = build_decl (UNKNOWN_LOCATION, FIELD_DECL, NULL_TREE,
-                          type);
-  field_align = ADJUST_FIELD_ALIGN (field, field_align);
-  ggc_free (field);
+      tree field = build_decl (UNKNOWN_LOCATION, FIELD_DECL, NULL_TREE, type);
+      field_align = ADJUST_FIELD_ALIGN (field, field_align);
+      ggc_free (field);
 #endif
-  align = MIN (align, field_align);
+      align = MIN (align, field_align);
+    }
   return align / BITS_PER_UNIT;
 }
 

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b8cd638dd7d0547699bee9c7a58ab264404d19ee..e77c6a1ff329673f82be769a0dfcf88414f7987f 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2014-10-10  Jakub Jelinek  <jakub@redhat.com>
+
+       PR c/63495
+       * gcc.target/i386/pr63495.c: New test.
+
 2014-10-10  Marek Polacek  <polacek@redhat.com>
 
        * c-c++-common/ubsan/object-size-1.c: New test.

diff --git a/gcc/testsuite/gcc.target/i386/pr63495.c b/gcc/testsuite/gcc.target/i386/pr63495.c
new file mode 100644 (file)
index 0000000..7f02f37
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr63495.c
@@ -0,0 +1,6 @@
+/* PR c/63495 */
+/* { dg-do compile { target { i?86-*-linux* x86_64-*-linux* } } } */
+/* { dg-options "-std=gnu11" } */
+
+struct __attribute__ ((aligned (8))) S { char c; };
+_Static_assert (_Alignof (struct S) >= 8, "wrong alignment");