PR 10450

	* dynobj.cc (Dynobj::create_gnu_hash_table): Add symbols to the
	GNU hash table if they need a dynamic value.  Otherwise, don't add
	them if they are defined in a dynamic object or are forced local.

diff --git a/gold/ChangeLog b/gold/ChangeLog
index 860eda95014d20c5a31dc954e52285abab02315a..8acaf87621b72feb9bbf75879d9c6fd0d0aeb578 100644 (file)
--- a/gold/ChangeLog
+++ b/gold/ChangeLog
@@ -1,3 +1,10 @@
+2009-12-30  Ian Lance Taylor  <iant@google.com>
+
+       PR 10450
+       * dynobj.cc (Dynobj::create_gnu_hash_table): Add symbols to the
+       GNU hash table if they need a dynamic value.  Otherwise, don't add
+       them if they are defined in a dynamic object or are forced local.
+
 2009-12-29  Ian Lance Taylor  <iant@google.com>
 
        PR 10450

diff --git a/gold/dynobj.cc b/gold/dynobj.cc
index ebb5f33ad9d0b18a849264827e2a576e8d0bb9aa..f982c4b469d395813b6c11319e35f5515ed3df29 100644 (file)
--- a/gold/dynobj.cc
+++ b/gold/dynobj.cc
@@ -959,9 +959,10 @@ Dynobj::create_gnu_hash_table(const std::vector<Symbol*>& dynsyms,
     {
       Symbol* sym = dynsyms[i];
 
-      // FIXME: Should put on unhashed_dynsyms if the symbol is
-      // hidden.
-      if (sym->is_undefined())
+      if (!sym->needs_dynsym_value()
+         && (sym->is_undefined()
+             || sym->is_from_dynobj()
+             || sym->is_forced_local()))
        unhashed_dynsyms.push_back(sym);
       else
        {