2003-05-23 Raoul Gough <RaoulGough@yahoo.co.uk>

	Committed by Elena Zannoni  <ezannoni@redhat.com>.
  	* coffread.c(coff_symtab_read): Do relocate static symbols from PE
	files, don't relocate absolute symbols (and do use mst_abs).

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9d3656bc968b9307852c587d1c92b010320bca6d..1cc7db174285f731fd266b3180064ac5a3648926 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2003-05-23  Raoul Gough  <RaoulGough@yahoo.co.uk>
+
+       Committed by Elena Zannoni  <ezannoni@redhat.com>.
+       * coffread.c(coff_symtab_read): Do relocate static symbols from PE
+       files, don't relocate absolute symbols (and do use mst_abs).
+
 2003-05-23  Andrew Cagney  <cagney@redhat.com>
 
        * objc-lang.c: Include "gdb_assert.h".

diff --git a/gdb/coffread.c b/gdb/coffread.c
index 6daf7b4acc59d6010d1adcb88b52de1793591736..81def0aac9c44b184796c3aaa2038493a9b23a98 100644 (file)
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -869,7 +869,6 @@ coff_symtab_read (long symtab_offset, unsigned int nsyms,
               print_address_symbolic work right without the (now
               gone) "set fast-symbolic-addr off" kludge.  */
 
-           /* FIXME: should use mst_abs, and not relocate, if absolute.  */
            enum minimal_symbol_type ms_type;
            int sec;
 
@@ -891,12 +890,23 @@ coff_symtab_read (long symtab_offset, unsigned int nsyms,
                  || cs->c_sclass == C_THUMBEXT ?
                  mst_bss : mst_file_bss;
              }
+           else if (cs->c_secnum == N_ABS)
+             {
+               /* Use the correct minimal symbol type (and don't
+                  relocate) for absolute values. */
+               ms_type = mst_abs;
+               sec = cs_to_section (cs, objfile);
+               tmpaddr = cs->c_value;
+             }
            else
              {
                sec = cs_to_section (cs, objfile);
                tmpaddr = cs->c_value;
-               if (cs->c_sclass == C_EXT || cs->c_sclass == C_THUMBEXTFUNC
-                   || cs->c_sclass == C_THUMBEXT)
+               /* Statics in a PE file also get relocated */
+               if (cs->c_sclass == C_EXT
+                   || cs->c_sclass == C_THUMBEXTFUNC
+                   || cs->c_sclass == C_THUMBEXT
+                   || (pe_file && (cs->c_sclass == C_STAT)))
                  tmpaddr += ANOFFSET (objfile->section_offsets, sec);
 
                if (sec == SECT_OFF_TEXT (objfile))