glsl: Construct gl_in with a location of -1.
authorPaul Berry <stereotype441@gmail.com>
Sun, 29 Sep 2013 15:19:13 +0000 (08:19 -0700)
committerPaul Berry <stereotype441@gmail.com>
Thu, 10 Oct 2013 21:26:53 +0000 (14:26 -0700)
We use a location of -1 for variables which don't have their own
assigned locations--this includes ir_variables which represent named
interface blocks.  Technically the location assigned to gl_in doesn't
matter, since gl_in is only accessed via its members (which have their
own locations).  But it's nice to be consistent.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
src/glsl/builtin_variables.cpp

index 7a64acc9e6d7a84cee8c92330a92e084327d55d6..6fc9183ad14c139fe2c69dca3134ddae20e1c8a8 100644 (file)
@@ -830,7 +830,7 @@ builtin_variable_generator::generate_varyings()
                                            GLSL_INTERFACE_PACKING_STD140,
                                            "gl_in");
       ir_variable *var = add_variable("gl_in", array(per_vertex_type, 0),
-                                      ir_var_shader_in, 0);
+                                      ir_var_shader_in, -1);
       var->init_interface_type(per_vertex_type);
    }
 }