re PR tree-optimization/66772 (ICE at -O2 and -O3 on x86_64-linux-gnu)

2015-07-06  Richard Biener  <rguenther@suse.de>

	PR tree-optimization/66772
	* tree-ssa-ccp.c (ccp_visit_phi_node): Make sure that copy
	values are available in the PHI node BB when there are
	still unexecutable edges.

	* gcc.dg/torture/pr66772-1.c: New testcase.
	* gcc.dg/torture/pr66772-2.c: Likewise.

From-SVN: r225459

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 7c43598d84359221e125c67e7de708c3702c7ceb..d3929fa41f680dbe86b144a397a1c38ad0edd590 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2015-07-06  Richard Biener  <rguenther@suse.de>
+
+       PR tree-optimization/66772
+       * tree-ssa-ccp.c (ccp_visit_phi_node): Make sure that copy
+       values are available in the PHI node BB when there are
+       still unexecutable edges.
+
 2015-07-06  Richard Biener  <rguenther@suse.de>
 
        PR tree-optimization/66767

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 32959d5f2cd60d23f7b2e4593f2036a3e6bf03b3..f7f15ddb74c68cdfd41a7262b30db1afe98c5038 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2015-07-06  Richard Biener  <rguenther@suse.de>
+
+       PR tree-optimization/66772
+       * gcc.dg/torture/pr66772-1.c: New testcase.
+       * gcc.dg/torture/pr66772-2.c: Likewise.
+
 2015-07-06  Andrew Bennett  <andrew.bennett@imgtec.com>
 
        * gcc.target/mips/near-far-3.c: Allow the call to near_func to use

diff --git a/gcc/testsuite/gcc.dg/torture/pr66733-1.c b/gcc/testsuite/gcc.dg/torture/pr66733-1.c
new file mode 100644 (file)
index 0000000..cb6e87c
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr66733-1.c
@@ -0,0 +1,28 @@
+/* { dg-do compile } */
+
+int a;
+
+int
+fn1 ()
+{
+  return 1;
+}
+
+void
+fn2 ()
+{
+  int b, j;
+  for (;;)
+    {
+      int c = 1;
+      if (j)
+       {
+         if (c)
+           break;
+       }
+      else
+       b = a;
+      fn1 () && b;
+      j = fn1 ();
+    }
+}

diff --git a/gcc/testsuite/gcc.dg/torture/pr66733-2.c b/gcc/testsuite/gcc.dg/torture/pr66733-2.c
new file mode 100644 (file)
index 0000000..6687bd0
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr66733-2.c
@@ -0,0 +1,46 @@
+/* { dg-do compile } */
+
+int a, b, c, e, f;
+
+void fn1 (int p) { }
+
+int
+fn2 (int p)
+{
+  return a ? p % a : 0; 
+}
+
+short
+fn3 (int p)
+{
+  return (1 >> p) < 1 ? 1 : p;
+}
+
+int
+fn4 ()
+{
+  int g = 0, h = 1;
+  if (b)
+    goto lbl;
+  fn2 (0);
+  if (fn3 (1))
+    fn1 (e && c);
+  if (h)
+    {
+      int i = 1;
+lbl:
+      if (i)
+       return 0;
+      for (; g < 1; g++)
+       ;
+    }
+  for (;;)
+    f || g > 0;
+}
+
+int
+main ()
+{
+  fn4 (); 
+  return 0;
+}

diff --git a/gcc/tree-ssa-ccp.c b/gcc/tree-ssa-ccp.c
index 496d84006fd7460245c739b0ba8be35fdb9cb47d..05a3e57333ec5452109c0cd68ecb2fea4b58c9f4 100644 (file)
--- a/gcc/tree-ssa-ccp.c
+++ b/gcc/tree-ssa-ccp.c
@@ -1081,6 +1081,7 @@ ccp_visit_phi_node (gphi *phi)
   new_val.mask = 0;
 
   bool first = true;
+  bool non_exec_edge = false;
   for (i = 0; i < gimple_phi_num_args (phi); i++)
     {
       /* Compute the meet operator over all the PHI arguments flowing
@@ -1121,6 +1122,22 @@ ccp_visit_phi_node (gphi *phi)
          if (new_val.lattice_val == VARYING)
            break;
        }
+      else
+       non_exec_edge = true;
+    }
+
+  /* In case there were non-executable edges and the value is a copy
+     make sure its definition dominates the PHI node.  */
+  if (non_exec_edge
+      && new_val.lattice_val == CONSTANT
+      && TREE_CODE (new_val.value) == SSA_NAME
+      && ! SSA_NAME_IS_DEFAULT_DEF (new_val.value)
+      && ! dominated_by_p (CDI_DOMINATORS, gimple_bb (phi),
+                          gimple_bb (SSA_NAME_DEF_STMT (new_val.value))))
+    {
+      new_val.lattice_val = VARYING;
+      new_val.value = NULL_TREE;
+      new_val.mask = -1;
     }
 
   if (dump_file && (dump_flags & TDF_DETAILS))