fix symtab.c

search_symbols had some bad code resulting in a cleanup being both
discarded and run.

	* symtab.c (search_symbols): Introduce a null cleanup for
	'retval_chain'.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1f07f38cc5fc1a2ff794d2a4b0b9687e82acd277..5331d5b16b3a4ddc05f0b1efcaf5a577ba071ad2 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-05-30  Tom Tromey  <tromey@redhat.com>
+
+       * symtab.c (search_symbols): Introduce a null cleanup for
+       'retval_chain'.
+
 2013-05-30  Tom Tromey  <tromey@redhat.com>
 
        * python/py-value.c (valpy_binop): Call do_cleanups before

diff --git a/gdb/symtab.c b/gdb/symtab.c
index def556b693faccb33e5301c9eb69af4de38550fa..9040035a928b292c33b940accccf57a496188934 100644 (file)
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -3529,7 +3529,7 @@ search_symbols (char *regexp, enum search_domain kind,
                                                &datum);
   }
 
-  retval_chain = old_chain;
+  retval_chain = make_cleanup (null_cleanup, NULL);
 
   /* Here, we search through the minimal symbol tables for functions
      and variables that match, and force their symbols to be read.