Remove some calls in tui_data_window

This patch removes a call to erase_data_content in refresh_all and
then removes some other calls that are more clearly unnecessary once
one follows calls from that point.

gdb/ChangeLog
2019-08-30  Tom Tromey  <tom@tromey.com>

	* tui/tui-regs.c (tui_data_window::display_registers_from_line)
	(tui_data_window::rerender): Don't call
	check_and_display_highlight_if_needed.
	(tui_data_window::refresh_all): Remove call to
	erase_data_content.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index c8b69f4d5258acfa918595cbf89c0b36472fc711..b95be65f6f57cb4211d31f1d6ce535f6613159e5 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-08-30  Tom Tromey  <tom@tromey.com>
+
+       * tui/tui-regs.c (tui_data_window::display_registers_from_line)
+       (tui_data_window::rerender): Don't call
+       check_and_display_highlight_if_needed.
+       (tui_data_window::refresh_all): Remove call to
+       erase_data_content.
+
 2019-08-30  Tom Tromey  <tom@tromey.com>
 
        * tui/tui-regs.c (tui_data_window::last_regs_line_no)

diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index 636ae101483afa74654483ee64b74a4db9c4af08..4a09a59044669c123dd2a512b3fa4b35d843c1bf 100644 (file)
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -339,8 +339,6 @@ tui_data_window::display_reg_element_at_line (int start_element_no,
 int
 tui_data_window::display_registers_from_line (int line_no)
 {
-  check_and_display_highlight_if_needed ();
-
   int element_no;
 
   if (line_no < 0)
@@ -427,7 +425,6 @@ tui_data_window::rerender ()
     {
       erase_data_content (NULL);
       delete_data_content_windows ();
-      check_and_display_highlight_if_needed ();
       display_registers_from (0);
     }
 }
@@ -450,10 +447,7 @@ tui_data_window::refresh_all ()
            first_line = line_from_reg_element_no (first_element);
 
          if (first_line >= 0)
-           {
-             erase_data_content (NULL);
-             display_registers_from_line (first_line);
-           }
+           display_registers_from_line (first_line);
        }
     }
 }